Bug 332545 - Tabbed Windows have only one tab close when main X clicked
Summary: Tabbed Windows have only one tab close when main X clicked
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: window-tabbing (show other bugs)
Version: 4.11.6
Platform: Mint (Ubuntu based) Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 04:38 UTC by Brock McNuggets
Modified: 2016-08-29 06:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brock McNuggets 2014-03-25 04:38:25 UTC
When you have multiple Windows tabs you can close each one individually. When you click the "Main" X, though, it only closes the front most tab.

Expectation: it should close all tabs, with appropriate warnings if files need to be saved. If that cannot be done, the X should not be there.

Reproducible: Always
Comment 1 Christoph Feck 2014-03-25 23:05:01 UTC
> the X should not be there.

Debatable. Since the main X is always at the same position, the user does not need to scan the tab bar to find the tab belonging to current visible window from the stack. Also Fitt's Law applies here.

KWin maintainers decide to close as wontfix.
Comment 2 Brock McNuggets 2014-03-25 23:38:18 UTC
Not expecting a change here, but if you look at every other implementation of tabs where there is a "main" close X it closes the window (well, everyone I can think of off hand): Dolphin windows, Firefox, Chrome, Konsole, GIMP, etc., they all have the main X close all tabs.
Comment 3 Thomas Lübking 2014-03-26 14:53:34 UTC
There's a fundamental difference between client internal tabs and tabs in a window manager, which collect various windows of random clients.
I think this discussion happened before and the result was that having the user clicking n-times the very same spot to close all windows in a tab collection is better than having him accidentally close all by what might be an attempt to only close the active one.

-1 from my side.
Comment 4 Brock McNuggets 2014-03-26 16:41:06 UTC
Disagree but the world does not yet revolve around me. :)

I do see the "Close Entire Group" option is easy to find.

Thank you.
Comment 5 pat_h 2014-06-19 08:30:10 UTC
So we have two different opinions, both with very good arguments. This sounds like a good case, where a configuration option makes sense. Another button would increase the clutter of the systemsettings dialogs.

As window grouping is a feature for advanced users anyway, I wouldn't mind putting it in an advanced dialogue. In the window decoration dialog, the window buttons can be configured. We could add another close button (initially it could be the same design, but different name in the button list of that configuration window). The only difference between the two close buttons would be that one of these closes only the active window in a tab group whereas the other one closes all windows of a tab group. The advantage ist, that this is already a dialog for advanced users plus you get the possibility to add both buttons to the window decoration, which might have it's use cases, too (sometimes you want to class the entire group, sometimes only half of it quickly).
Comment 6 Martin Flöser 2016-08-29 06:45:29 UTC
Unfortunately the rework in decorations in KWin 5 resulted in the window tabbing feature to be lost. We still want to bring this feature back, but after several versions it still hasn't emerged yet. Given that I think it is time to adjust the status of this bug report. The new implementation would be different anyway and it's questionable whether this report would still apply to it.