Bug 332280 - freerotationfilter.cpp:92: (style) Same expression on both sides of '||'.
Summary: freerotationfilter.cpp:92: (style) Same expression on both sides of '||'.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Filters (show other bugs)
Version: 4.0.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 12:34 UTC by dcb314
Modified: 2014-09-02 15:03 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/digikam/5ac520779fce2238610e07936ca8ecaa7802a177
Version Fixed In: 4.0.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2014-03-18 12:34:32 UTC 
Source code is

    if (p1.x() < 0 ||
        p2.y() < 0 ||
        p1.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

Maybe something like

    if (p1.x() < 0 ||
        p1.y() < 0 ||
        p2.x() < 0 ||
        p2.y() < 0)
    {
        return 0.0;
    }

was intended.
Comment 1 caulier.gilles 2014-03-18 12:49:28 UTC 
Git commit 5ac520779fce2238610e07936ca8ecaa7802a177 by Gilles Caulier.
Committed on 18/03/2014 at 12:47.
Pushed by cgilles into branch 'master'.

fix comparison arguments in head of calculateAngle fonction
FIXED-IN: 4.0.0

M  +22   -24   libs/dimg/filters/transform/freerotationfilter.cpp
M  +5    -5    libs/dimg/filters/transform/freerotationfilter.h

http://commits.kde.org/digikam/5ac520779fce2238610e07936ca8ecaa7802a177