Bug 332276 - Implement additional Xen hypercalls
Summary: Implement additional Xen hypercalls
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 10:52 UTC by Ian Campbell
Modified: 2014-05-01 08:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Tarball of patches (60.00 KB, application/x-tar)
2014-03-18 10:53 UTC, Ian Campbell
Details
Second attempt at attaching correct patches (20.00 KB, application/x-tar)
2014-04-28 15:26 UTC, Ian Campbell
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Campbell 2014-03-18 10:52:42 UTC
Andrew Cooper has implemented a few additional hypercalls. With these patches, valgrind can now instrument xen-4.4 based toolstacks, and qemu-traditional looking after an HVM domain.

There are seven patches which I have attached as a tarball.

Thanks,
Ian.

Reproducible: Always
Comment 1 Ian Campbell 2014-03-18 10:53:12 UTC
Created attachment 85628 [details]
Tarball of patches
Comment 2 Bart Van Assche 2014-04-26 14:54:34 UTC
Can you rebase these patches on the current trunk ? The first patch of the series doesn't apply:
$ patch -p1 --dry-run -f <~/0001-xen-Fix-XEN_SYSCTL_getdomaininfolist-for-version-0xa.patch 
checking file coregrind/m_syswrap/syswrap-xen.c
Hunk #1 succeeded at 1034 with fuzz 2 (offset 633 lines).
Hunk #2 FAILED at 812.
1 out of 2 hunks FAILED
checking file include/vki/vki-xen-sysctl.h
Hunk #1 succeeded at 86 (offset 30 lines).
Hunk #2 FAILED at 148.
1 out of 2 hunks FAILED
Comment 3 Ian Campbell 2014-04-28 15:25:59 UTC
Hi Bart,

I think I may have attached the wrong tarball, those patches look like they were applied in December! e.g. r13725 is the first one.

I'll try again. The patches should be:
0001-Fix-P-RE-OST-_XEN_HVMOP_-READ-WRITE.patch
0002-syswrap-XEN_DOMCTL_settimeoffset.patch
0003-syswrap-XEN_DOMCTL_cacheflush.patch
0004-syswrap-XEN_HVMOP_set_isa_irq_level.patch
0005-syswrap-XEN_HVMOP_set_pci_link_route.patch
0006-syswrap-XEN_HVMOP_set_mem_type.patch
0007-syswrap-XEN_DOMCTL_resumedomain.patch
Comment 4 Ian Campbell 2014-04-28 15:26:41 UTC
Created attachment 86314 [details]
Second attempt at attaching correct patches
Comment 5 Bart Van Assche 2014-05-01 08:12:20 UTC
Thanks - applied the seven patches as r13922..13928 on the trunk.