Bug 332107 - kde's <prefix>/share *always* prepended to XDG_DATA_DIRS
Summary: kde's <prefix>/share *always* prepended to XDG_DATA_DIRS
Status: RESOLVED FIXED
Alias: None
Product: kde
Classification: I don't know
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Andreas Hartmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-13 18:10 UTC by Rex Dieter
Modified: 2015-10-08 13:30 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rex Dieter 2014-03-13 18:10:20 UTC
Since
https://git.reviewboard.kde.org/r/109675/

My XDG_DATA_DIRS on fedora ends up being
/usr/share:/usr/share/kde-settings/kde-profile/default/share:/usr/local/share:/usr/share

I would argue that users' env values for XDG_DATA_DIRS should not get trumped if
* kde's prefix is either default (/usr or /usr/local)
or, more particularly,
* <kde_prefix>/share is already contained in XDG_DATA_DIRS

Reproducible: Always
Comment 1 Rex Dieter 2014-03-13 18:14:17 UTC
marking confirmed, several users reported this on irc today, before I investigated and found the cause here.
Comment 2 Rex Dieter 2014-03-13 18:17:24 UTC
Hrm, missed part of my initial comment.  My point was that we purposely want
/usr/share/kde-settings/kde-profile/default/share to come first (and set XDG_DATA_DIRS accordingly), but the aforementioned commit makes that impossible.
Comment 3 Rex Dieter 2014-03-13 18:21:55 UTC
See also bug #315452 includes patch (though prior to this commit), and seems to implement what I think should happen.
Comment 4 Kevin Kofler 2014-03-13 18:27:37 UTC
Yeah, this regression broke our default applications in Fedora KDE, and we only just now figured out why more or less by accident.

By the way, we changed Fedora KDE packaging to replace the startkde.cmake with a known-good patched copy (we were already making many changes to the script) so that we will NOT pick up such regressions in the future.

(In Fedora packaging, we just deleted the whole added hunk, because it is entirely useless for a distro-installed KDE in /usr.)
Comment 5 Rex Dieter 2015-10-08 13:30:38 UTC
fixed in plasma-workspace now