Bug 332024 - Popups in plasma-shell creates entry named plasma_shell in task manager and then deletes entry
Summary: Popups in plasma-shell creates entry named plasma_shell in task manager and t...
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: libplasmaquick (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 345890 347354 354608 356510 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-11 12:39 UTC by Bhushan Shah
Modified: 2016-03-19 08:04 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Animated gif that shows problem (2.42 MB, image/gif)
2014-03-11 12:39 UTC, Bhushan Shah
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bhushan Shah 2014-03-11 12:39:20 UTC
Created attachment 85529 [details]
Animated gif that shows problem

This happens so fast it is not visible but I managed to create animated gif for it
Comment 1 Marco Martin 2014-03-11 16:11:40 UTC
i think the culript is that qt does set its own states, then we have to overwrite them, but it's after the window has been shown, so there is a little instantflags are wrong :/
Comment 2 Hrvoje Senjan 2014-03-20 18:28:46 UTC
this one is resolved i think, for a few days at least
Comment 3 Bhushan Shah 2014-03-21 03:46:54 UTC
(In reply to comment #2)
> this one is resolved i think, for a few days at least

hmm, no at first taskbar entry was visible but now it is not visible normally but gets created and gets destroyed too fast..
Comment 4 Martin Klapetek 2014-03-26 10:51:50 UTC
I can reproduce only with Kickoff, it does indeed get created and removed really fast. Confirming.
Comment 5 Marco Martin 2014-04-03 10:08:38 UTC
seems that qt resets the window flags at the wrong moment, probably not much we can do about
Comment 6 Martin Flöser 2014-04-03 10:24:54 UTC
(In reply to comment #5)
> seems that qt resets the window flags at the wrong moment, probably not much
> we can do about

well there are few things which come to my mind:
* fix Qt (implement all the flags we need)
* don't create the taskbar entry instantly but wait a little bit to get updates
Comment 7 Bhushan Shah 2014-04-11 15:45:45 UTC
so? ping!
Comment 8 Martin Klapetek 2014-08-11 13:33:53 UTC
I can still see this sometimes when opening kickoff after logging in
Comment 9 Martin Klapetek 2015-01-22 00:50:32 UTC
Still a thing in latest master.

Given Martin's comment in #6 -- "* don't create the taskbar entry instantly but wait a little bit to get updates" -- this might sort it out, so I'm adding Eike to CC for comments.
Comment 10 Eike Hein 2015-01-22 13:23:39 UTC
That would have to be a last resort, IMHO. Adding magic value delays to the system decreases its responsiveness and increases its complexity by no longer simply directly representing state. It also tends to be very hard to take magic timers out again once they're there, starting with anybody having to know they're there. The TM has to be pragmatic sometimes and work around others' crap, but an exception for every Plasma popup - our own windows - doesn't sit right.
Comment 11 Kai Uwe Broulik 2015-04-05 16:38:37 UTC
*** Bug 345890 has been marked as a duplicate of this bug. ***
Comment 12 Bhushan Shah 2015-05-08 03:49:36 UTC
*** Bug 347354 has been marked as a duplicate of this bug. ***
Comment 13 Martin Klapetek 2015-09-04 16:11:13 UTC
Somewhat directly related bug caused by this -- https://bugs.kde.org/show_bug.cgi?id=352278
Comment 14 Kai Uwe Broulik 2015-11-14 11:18:19 UTC
*** Bug 354608 has been marked as a duplicate of this bug. ***
Comment 15 Eike Hein 2015-12-11 14:36:21 UTC
*** Bug 356510 has been marked as a duplicate of this bug. ***
Comment 16 Nikola Schnelle 2016-01-15 00:03:33 UTC
Any news about this bug? For me this ghost entry is very visible and makes taskbar/panel to flicker/flash.

Video: https://www.dropbox.com/s/iznqz20ukq4v3cq/2016-01-13%2013.09.04.mp4?dl=0
Comment 17 David Edmundson 2016-03-15 14:36:19 UTC
Git commit 42e924e7f61e7b36266e6c3ca07aa414e88f50ca by David Edmundson.
Committed on 15/03/2016 at 14:34.
Pushed by davidedmundson into branch 'master'.

Fix taskbar flicking when opening Plasma popups

When we show a Qt window it resets all wm_states, including the
SKIP_TASKBAR state that Qt doesn't support see
QXcbWindow::setNetWmStates

In order to set the flag we need to do it after Qt has mapped the
window.

This was previously done using ExposeEvent which will happen after show,
but by it being a separate event the task manager will get notified in
the meantime.

By merging into the same event we can make sure the flag is set before
the task manager processes it.
REVIEW: 127374

M  +13   -4    src/plasmaquick/dialog.cpp

http://commits.kde.org/plasma-framework/42e924e7f61e7b36266e6c3ca07aa414e88f50ca
Comment 18 David Rosca 2016-03-19 08:04:06 UTC
Git commit 28b4400da8481251084ac38b26b4347703a3ab54 by David Rosca.
Committed on 19/03/2016 at 08:02.
Pushed by drosca into branch 'master'.

Dialog: Set SkipTaskbar/Pager states before showing window

This sets the states before showing the window and is a proper fix
for the linked bug.

Needs e4cea305ed2ba3c9f580bf9d16c59a1048af0e8a from qtbase - Qt 5.6.1
REVIEW: 127422

M  +4    -0    src/plasmaquick/dialog.cpp

http://commits.kde.org/plasma-framework/28b4400da8481251084ac38b26b4347703a3ab54