Extend the existing .kml unit tests in tests/data or add new ones to maximize the test coverage of tag writers. See the kml reference at https://developers.google.com/kml/documentation/kmlreference as well as the following test coverage reports: - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlBalloonStyleTagWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlCameraTagWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlFlyToTagWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlListStyleTagWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlPhotoOverlayWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlPointTagWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlTimeSpanWriter.cpp.gcov.html - http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/KmlTimeStampTagWriter.cpp.gcov.html To maximize the test coverage, add tags / values in the .kml files for the lines marked orange in the test coverage report (except Q_ASSERT( false && "not reachable" ); in KmlTimeStampTagWriter.cpp.gcov.html). Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestGeoDataWriter and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers. Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
I want to work on this task.
Git commit dd619961e97e926a02d4cb0d5cfa6a11d81fa362 by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian. Committed on 07/03/2014 at 21:23. Pushed by nienhueser into branch 'master'. Extend KML unit test coverage of tag writers REVIEW: 116644 M +1 -2 src/lib/marble/geodata/handlers/kml/KmlFlyToModeTagHandler.cpp M +50 -5 tests/data/AltitudeMode.kml M +1 -1 tests/data/CDATATest.kml M +6 -2 tests/data/CameraLookAt.kml M +1 -1 tests/data/Geometries.kml C +12 -3 tests/data/ListStyleTest1.kml [from: tests/data/Track.kml - 075% similarity] C +12 -3 tests/data/ListStyleTest2.kml [from: tests/data/Track.kml - 075% similarity] C +12 -3 tests/data/ListStyleTest3.kml [from: tests/data/Track.kml - 075% similarity] C +12 -3 tests/data/ListStyleTest4.kml [from: tests/data/Track.kml - 075% similarity] C +11 -3 tests/data/ListStyleTest5.kml [from: tests/data/Track.kml - 077% similarity] C +13 -6 tests/data/LookAtTest.kml [from: tests/data/Tour.kml - 058% similarity] M +20 -0 tests/data/PhotoOverlayInFolder.kml M +5 -4 tests/data/Tour.kml M +12 -3 tests/data/Track.kml http://commits.kde.org/marble/dd619961e97e926a02d4cb0d5cfa6a11d81fa362