Bug 331665 - muon-updater prompts to click missing "Check for updates" button
Summary: muon-updater prompts to click missing "Check for updates" button
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Updates (interactive) (show other bugs)
Version: unspecified
Platform: Kubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Jonathan Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-01 22:32 UTC by skierpage
Modified: 2016-03-02 13:27 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
muon-updater with prompt to click missing button (41.81 KB, image/png)
2014-03-02 00:37 UTC, skierpage
Details

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2014-03-01 22:32:52 UTC
When I open the updater from the system tray alert or by running it, it invites me to click a button that isn't there.

Reproducible: Always

Steps to Reproduce:
1. open muon-updater

Actual Results:  
Its Software Updates window is mostly blank and shows the message:


   It is unknown when the last check for updates was.
  Please click Check for Updates to check.

But there is no Check for Updates anywhere, not even in the [More...v] menu. I'll attach a screenshot.

This eventually is replaced by the available software to update and the [ Install Updates] button enables (or, it is replaced by "The software on this computer is up to date. Last checked XX hours ago"). But while it's on-screen it makes no sense.

Expected Results:  
Don't invite me to click a button that isn't there.

I don't know whether the "It is unknown when" message itself is a bug, it appears even though muon-updater ran successfully last time.

If I run from the command line, the console has the errors:
QDBusConnection: session D-Bus connection created before QCoreApplication. Application may misbehave.
QDBusConnection: session D-Bus connection created before QCoreApplication. Application may misbehave.
Object::connect: No such signal org::freedesktop::UPower::DeviceAdded(QDBusObjectPath)
Object::connect: No such signal org::freedesktop::UPower::DeviceRemoved(QDBusObjectPath)
JSonScanner::yylex - error reading from io device
JSonScanner::yylex - error reading from io device

This is on Kubuntu 13.10, Muon Update Manager 2.1.3 on KDE 4.11.5

I reported this in Launchpad https://bugs.launchpad.net/ubuntu/+source/muon/+bug/1286422 and Harald Sitter suggested I report it here. From Launchpad:

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: muon-updater 2.1.3-0ubuntu0.2
ProcVersionSignature: Ubuntu 3.11.0-18.32-generic 3.11.10.4
Uname: Linux 3.11.0-18-generic x86_64
ApportVersion: 2.12.5-0ubuntu2.2
Architecture: amd64
Date: Fri Feb 28 18:39:01 2014
MarkForUpload: True
SourcePackage: muon
UpgradeStatus: Upgraded to saucy on 2013-10-21 (130 days ago)
Comment 1 skierpage 2014-03-02 00:37:14 UTC
Created attachment 85376 [details]
muon-updater with prompt to click missing button

"Check for Updates" is not in the [More...v] menu when this is on-screen.
Comment 2 skierpage 2014-03-02 00:45:41 UTC
Now when I run muon-updater, the prompt quickly goes away and is replaced by a loading animation.  After 15 seconds or so the Software Updates window changes to 
  The software on this computer is up to date.
  Last checked 8 hours and 48 minutes ago.
and now the [More...v] menu *does* contain Check for Updates.

But that loading animation wasn't appearing the many times I tried this before filing this bug.
Comment 3 Nikola Schnelle 2014-03-02 11:04:05 UTC
I was experiencing this bug too. But it seems to be fixed in 2.2 alpha1 (2.1.70), Kubuntu 14.04.
Comment 4 Harald Sitter 2014-03-03 11:08:19 UTC
## Analysis
UpdaterWidget.cpp is a stack widget with two pages, one is the actual updaterview, the other is the !updaterview. Which one is shown depends on a whole bunch of factors.

The involved key functions are 
UpdaterWidget::checkUpToDate (which actually sets the initial state after construction)
and
UpdaterWidget::activityChanged (which adjusts the page based on resource states)

Latter is run more than once whenever the resoruce state changes it appears, and states appear randomly different on 2.1 compared to 2.2. Namely at one point both conditions inside that function are false on 2.2 (which leaves the page as it were), while on 2.2 at the same step they are true/false respectively thus forcing the page to be set to the updateview. So this suggests that there is a state bug somewhere in the resources in 2.1 which is fixed in 2.2.

## Why we'll likely not want to spend time on this
Personally I do not think we'll want to pursue this as the 2.1 series is only present in Kubuntu 13.10 (EOL in May) and this bug does not have any implications other than the "you need to update" widget being shown until the actual cache parsing is started. It does not in any way affect functionality of the updater.
Comment 5 Aleix Pol 2015-01-14 16:17:50 UTC
It should be fixed (as of 2.2 actually). Closing.