Bug 331594 - Information messages dialog always open behind Preview and Piece holder windows
Summary: Information messages dialog always open behind Preview and Piece holder windows
Status: RESOLVED FIXED
Alias: None
Product: palapeli
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Stefan Majewsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-28 03:36 UTC by André Marcelo Alvarenga
Modified: 2014-02-28 23:33 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.13
Sentry Crash Report:


Attachments
Screenshot (402.81 KB, image/png)
2014-02-28 03:37 UTC, André Marcelo Alvarenga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description André Marcelo Alvarenga 2014-02-28 03:36:58 UTC
I think the information messages should stay ahead of the Preview and Piece holder windows because it's necessary to move them to click on the OK button.


See screenshot.

Reproducible: Always




Using Project Neon - Palapeli 2.0 preview.

This problem doesn't occur with Configure Palapeli dialog.
Comment 1 André Marcelo Alvarenga 2014-02-28 03:37:52 UTC
Created attachment 85354 [details]
Screenshot
Comment 2 Ian Wadham 2014-02-28 22:42:21 UTC
Normally the Preview and Piece Holder windows should be pushed to one side, otherwise they get in the way of the puzzle you are solving. So the message boxes will not usually be overlaid.

However, it is possible to expand a piece holder window. That can be necessary in a large puzzle where the holder can contain 100 or more pieces or you wish to use it to pre-assemble part of the solution. In that situation, a message can be issued, the message box can be completely obscured, the expanded piece holder appears frozen and the user seems to have lost control of the game. Not nice.

I will be submitting a fix to the KDE 4.13 branch soon, so that the message boxes will always come out on top.
Comment 3 Ian Wadham 2014-02-28 23:19:41 UTC
Git commit 49eb5b047e96ff83dc4d0c2b0386290c90e867f5 by Ian Wadham.
Committed on 28/02/2014 at 23:09.
Pushed by ianw into branch 'master'.

The windows needed to have parents but not Qt::WindowStaysOnTopHint.

M  +2    -2    src/engine/gameplay.cpp
M  +3    -2    src/engine/puzzlepreview.cpp
M  +1    -1    src/engine/puzzlepreview.h
M  +5    -5    src/window/pieceholder.cpp
M  +2    -3    src/window/pieceholder.h

http://commits.kde.org/palapeli/49eb5b047e96ff83dc4d0c2b0386290c90e867f5
Comment 4 Ian Wadham 2014-02-28 23:25:17 UTC
Git commit cc38b50a7d7d052d3166d9249e12a6369a90dc14 by Ian Wadham.
Committed on 28/02/2014 at 23:09.
Pushed by ianw into branch 'KDE/4.13'.

The windows needed to have parents but not Qt::WindowStaysOnTopHint.

M  +2    -2    src/engine/gameplay.cpp
M  +3    -2    src/engine/puzzlepreview.cpp
M  +1    -1    src/engine/puzzlepreview.h
M  +5    -5    src/window/pieceholder.cpp
M  +2    -3    src/window/pieceholder.h

http://commits.kde.org/palapeli/cc38b50a7d7d052d3166d9249e12a6369a90dc14