Bug 331504 - Enter in crop mode exits it instead of applying changes
Summary: Enter in crop mode exits it instead of applying changes
Status: RESOLVED DUPLICATE of bug 313806
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: 4.11.5
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-25 20:09 UTC by Vitaliy Filippov
Modified: 2017-05-12 15:56 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch to display a dialogue upon pressing Enter in Image View mode with an active tool. (1.57 KB, patch)
2014-02-28 20:20 UTC, Shlomi Fish
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaliy Filippov 2014-02-25 20:09:46 UTC
Hi!
I want to report a small usability problem in gwenview: when you press Enter during cropping image it exits crop mode and exits image view mode and goes into gallery mode.
It's totally unintutive. gwenview should apply changes on Enter press.

Reproducible: Always

Steps to Reproduce:
1. open some image
2. select edit -> crop
3. press enter
Actual Results:  
gwenview exist image view mode

Expected Results:  
gwenview should apply the transformation
Comment 1 Shlomi Fish 2014-02-28 15:44:07 UTC
I can confirm that here ( gwenview-4.12.2-1.mga5 on kdebase4-workspace-4.11.6-1.mga5 , KDE-4.12.x ) on Mageia Linux x86-64 Cauldron. However, it is possible that instead of applying the crop, the "Enter" should simply do nothing (to avoid misapplying a crop by accident), and the crop will only be applied on pressing Alt+C/etc.

Regards,

-- Shlomi Fish
Comment 2 Shlomi Fish 2014-02-28 20:20:19 UTC
Created attachment 85368 [details]
Patch to display a dialogue upon pressing Enter in Image View mode with an active tool.

This patch should fix the more general problem of switching away from the image window when Qt::Key_Return ("Enter") is pressed. It is done against origin/KDE/4.12 (which was the latest version I was able to build on my Mageia machine - git master had too many dependencies that I didn't have) so may not apply cleanly on master and other branches.
Comment 3 Vitaliy Filippov 2014-03-01 13:48:21 UTC
(In reply to comment #1)
> "Enter" should simply do nothing (to avoid misapplying a crop by accident),

Hm... I think "Enter" key press is rarely an accident, I think "apply changes" is the normal meaning of Enter key in most applications :)

And the operation is non-destructive, so you can easily recover from an accident...

Maybe just apply changes on enter? It's more convenient than alt-c or something like that (for example I didn't know about that hotkey at all)
Comment 4 Shlomi Fish 2014-03-03 14:48:20 UTC
Hi Vitaliy,

(In reply to comment #3)
> (In reply to comment #1)
> > "Enter" should simply do nothing (to avoid misapplying a crop by accident),
> 
> Hm... I think "Enter" key press is rarely an accident, I think "apply
> changes" is the normal meaning of Enter key in most applications :)

Enter can be pressed accidentally in many cases, and not all applications use the "apply changes" meaning to it. In gwenview, it means switching between the active image and the browse mode, and I believe this meaning should not be conflated with applying the current changes. 

> 
> And the operation is non-destructive, so you can easily recover from an
> accident...

Also if you press enter twice (to get to browse mode)?

> 
> Maybe just apply changes on enter? It's more convenient than alt-c or
> something like that (for example I didn't know about that hotkey at all)

The "C" in the "Crop" button is underlined which indicates a keyboard shortcut, and I think it would be preferable for such operations to not be done accidentally.

Regards,

-- Shlomi Fish
Comment 5 KDE Neon user 2016-07-11 14:06:19 UTC
@Shlomi (In reply to Shlomi Fish from comment #4)

Please reconsider this. When editing a crop, the expected behavior of the enter key is to apply the selected area, regardless of what the enter key does when the crop tool isn't in use. That's what happens in all image editors with a crop feature, such as Gimp and Krita. 

Also:

- if the user is in the middle of a crop, he isn't interested in changing view modes, but finishing his crop.

- Crop areas are selected with the mouse. There's no obvious risk of pressing the enter key accidently while you are using your mouse/touchpad.

- You can add an option to keep the old behavior.

More users have requested it at: https://bugs.kde.org/show_bug.cgi?id=313806
Comment 6 Christoph Feck 2017-05-12 15:56:26 UTC

*** This bug has been marked as a duplicate of bug 313806 ***