Adding widget documentation to an object widget of a sequence diagram through the widget property dialog do not add documentation. Adding documentation through the doc windows works. Reproducible: Always Steps to Reproduce: 1. open umbrello 2. create a sequence diagram 3. add two objects 4. Double click on an object and edit documentation 5. Save propertes Actual Results: Reopen the widget property dialog do not show the entered documentation. Expected Results: The documentation should be added to the widget
looks similar to bug 255424
There seems to be a logic failure: The doc is saved into the widget in void ClassGenPage::updateObject(). On the next mouse click the widgets doc is overwritten from DocWindow::updateDocumentation 0 UMLObject::setDoc umlobject.cpp 422 0x63fa60 1 DocWindow::updateDocumentation docwindow.cpp 222 0x5ee397 2 DocWindow::showDocumentation docwindow.cpp 156 0x5ee6bf 3 UMLScene::mousePressEvent umlscene.cpp 851 0x6485bd
Git commit 864832c0d310197c8b0cc8c941fdefec27d923e7 by Felix Rohrbach. Committed on 28/09/2014 at 21:17. Pushed by felixr into branch 'master'. Fix creation of documentation for UML-Components This fixes two issues connected to the DocWindow. 1. When DocWindow::showDocumentation is called, it checks whether it is called with the same UMLObject/Scene/... But it missed that UMLObjects and UMLScenes might be passed to the function embedded in a widget. 2. The overwrite parameter of DocWindow::showDocumentation did the opposite of what the documentation said. I changed it to match the documentation and adjusted a few functions using it wrong. Related: bug 255424 FIXED-IN: 4.14.2 REVIEW: 120369 M +34 -15 umbrello/docwindow.cpp M +2 -2 umbrello/umlscene.cpp M +1 -0 umbrello/widgets/associationwidget.cpp M +1 -1 umbrello/widgets/notewidget.cpp http://commits.kde.org/umbrello/864832c0d310197c8b0cc8c941fdefec27d923e7
Git commit a802474df0a660e4cf6bfdd360b6bb8a692b89ba by Ralf Habacker, on behalf of Felix Rohrbach. Committed on 28/09/2014 at 21:17. Pushed by habacker into branch 'master'. Fix creation of documentation for UML-Components This fixes two issues connected to the DocWindow. 1. When DocWindow::showDocumentation is called, it checks whether it is called with the same UMLObject/Scene/... But it missed that UMLObjects and UMLScenes might be passed to the function embedded in a widget. 2. The overwrite parameter of DocWindow::showDocumentation did the opposite of what the documentation said. I changed it to match the documentation and adjusted a few functions using it wrong. Related: bug 255424 FIXED-IN: 4.14.2 REVIEW: 120369 M +34 -15 umbrello/docwindow.cpp M +2 -2 umbrello/umlscene.cpp M +1 -0 umbrello/widgets/associationwidget.cpp M +1 -1 umbrello/widgets/notewidget.cpp http://commits.kde.org/umbrello/a802474df0a660e4cf6bfdd360b6bb8a692b89ba