Bug 331137 - git->Show Differences closes file
Summary: git->Show Differences closes file
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: All editors (other bugs)
Version First Reported In: git master
Platform: Debian unstable Linux
: NOR normal
Target Milestone: 4.6.1
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-02-14 12:37 UTC by peje66
Modified: 2016-03-14 19:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.0.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description peje66 2014-02-14 12:37:57 UTC 
I want to see what changes have been done to current file.
Right click in editor of open file
select Git->Show Differences from menu

Select "Finish Review"
Now the file is closed. I expect the file to still be open.

Doing Git->Commit and then "Cancel Review" accomplishes the same but keeps the file open


 

Reproducible: Always

Steps to Reproduce:
We have a file t.cpp which is checked in to git and later modified
1. Open file in kdevelop
2. Right click in editor window
3. select Git->"Show Differences"
4. Select "Finish Review"

Actual Results:  
t.cpp is closed

Expected Results:  
t.cpp should still be open in editor
Comment 1 Kevin Funk 2014-02-14 12:51:19 UTC 
Indeed. That looks broken.
Comment 2 Mathias Tillman 2014-09-05 08:26:28 UTC 
This doesn't seem to happen for me using KDevelop 4.6.0 with KDE 4.14.0, was it fixed recently?
Comment 3 peje66 2014-09-05 13:14:56 UTC 
On 2014-09-05 10:26, Mathias Tillman wrote:
> https://bugs.kde.org/show_bug.cgi?id=331137
>
> Mathias Tillman <master.homer@gmail.com> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |master.homer@gmail.com
>
> --- Comment #2 from Mathias Tillman <master.homer@gmail.com> ---
> This doesn't seem to happen for me using KDevelop 4.6.0 with KDE 4.14.0, was it
> fixed recently?
>
I have just tried it with latest kde4-legacy. 4.7.60 kde 4.14.0

The first time i try "git->show difference" after starting kdevelop it
works as expected, second time it fails as described in the bug-report.

/Pär-Ola
Comment 4 Francis Herne 2016-03-14 16:37:15 UTC 
This doesn't happen (AFAICT) with KDevelop 4.90.91 or current 5.0 branch. The tab remains open when leaving the diff view.
Comment 5 peje66 2016-03-14 19:07:58 UTC 
It works for me too. Maybe time to close this bug
Comment 6 Kevin Funk 2016-03-14 19:25:25 UTC 
Thanks for the feedback. Closing.