Bug 331043 - JJ: Resize arrows doesn't flip when transforming while using mirror view
Summary: JJ: Resize arrows doesn't flip when transforming while using mirror view
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Transform (show other bugs)
Version: 2.8 Beta
Platform: Microsoft Windows All
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 12:01 UTC by Chris Cotish
Modified: 2014-05-03 05:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Fix resize arrows in Mirror Mode (1.89 KB, patch)
2014-04-20 18:11 UTC, Koushik S
Details
Fix resize arrows in tranform tool (1.88 KB, patch)
2014-04-27 14:59 UTC, Koushik S
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cotish 2014-02-12 12:01:36 UTC
Corner resize arrows are shown wrongly when transforming while using mirror view. They should be facing the other way when the view is mirrored.

Reproducible: Always

Steps to Reproduce:
1. Select Transform a layer or selection
2. Enable Mirror View
3. Hover over one of 4 corner till diagonal arrows icon shows up
Actual Results:  
Icon is not flipped like it should be.


Windows 8
Comment 1 Halla Rempt 2014-02-12 12:03:05 UTC
Ha, yes! Well spotted!
Comment 2 Koushik S 2014-04-20 18:11:37 UTC
Created attachment 86189 [details]
Fix resize arrows in Mirror Mode

Patch aims to fix the resize arrows when in mirror mode. 

Any suggestions on improving the code is welcome.
Comment 3 Dmitry Kazakov 2014-04-21 07:08:05 UTC
Hi, Koushik!

Your patch is ok, except the new public method of KisCanvas2. You need to either call the method of the coordinatesConverter() directly from the transform tool (which is ok, see the code of KisPaintopTransformationConnector), or extend the interface of KisCanvasController, which is in charge of the transformations of the canvas. If you choose the latter method, please also note that the canvas also supports vertical mirroring transformation, so choose naming accordingly :)
Comment 4 Koushik S 2014-04-27 14:59:03 UTC
Created attachment 86294 [details]
Fix resize arrows in tranform tool

I've made some changes as you requested.
Comment 5 Dmitry Kazakov 2014-05-03 05:10:55 UTC
Git commit 60cd9bd1fe7b94c21a914ab7b9de2bbd2434977a by Dmitry Kazakov.
Committed on 03/05/2014 at 05:07.
Pushed by dkazakov into branch 'master'.

Fix Transfrom Tool arrows on mirrored canvas

Thanks Koushik S for preparing this patch!
CCMAIL:skoushik333@gmail.com

M  +10   -1    krita/plugins/tools/tool_transform2/kis_tool_transform.cc

http://commits.kde.org/calligra/60cd9bd1fe7b94c21a914ab7b9de2bbd2434977a