Bug 331020 - firefox-beta segfaulting in oxygen-gtk3 (Oxygen::MenuBarStateEngine::animatedRectangleIsValid)
Summary: firefox-beta segfaulting in oxygen-gtk3 (Oxygen::MenuBarStateEngine::animated...
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk3-engine (show other bugs)
Version: 1.3.3
Platform: Mageia RPMs Linux
: NOR grave
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
: 331475 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-02-11 21:14 UTC by tv
Modified: 2014-03-11 08:39 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
GDB trace with symbols (5.36 KB, text/plain)
2014-02-11 21:14 UTC, tv
Details
patch (2.61 KB, text/x-diff)
2014-02-12 09:37 UTC, Hugo Pereira Da Costa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tv 2014-02-11 21:14:21 UTC
Using current Mageia Cauldron (oxygen-gtk3-1.3.3, firefox-beta-28) I experience segfaults with firefox-beta & oxygen.
I usually run ff from a terminal in my wife session but this time, I opened my own session in order to investigate a gnome issue. In that session, ff always segfaulted in oxygen-gtk3.
See attached trace.
Oxygen::render_frame() called Oxygen::MenuBarStateEngine::animatedRectangleIsValid() with a NULL pointer...

Reproducible: Always

Steps to Reproduce:
1. run firefox-beta
2.
3.
Actual Results:  
segfaults

Expected Results:  
happy session
Comment 1 tv 2014-02-11 21:14:48 UTC
Created attachment 85105 [details]
GDB trace with symbols
Comment 2 Hugo Pereira Da Costa 2014-02-11 21:20:57 UTC
yes ... 
oxygen-gtk3 probably lacks many checks on the actual widget's validity (not null) since it was assumed to always be the case for "native" gtk applications.
Now that non native apps are being ported, we'll probably end up with either 
- many more checks (good)
- many hacks similar to what we have in the gtk2 case.

I'll try firefox-gtk3 to fix this one (should be easy) and the likely many other similar crashes that will happen (less easy).

Thanks for reporting, will keep you posted.
Comment 3 Hugo Pereira Da Costa 2014-02-12 09:37:38 UTC
Created attachment 85109 [details]
patch
Comment 4 Hugo Pereira Da Costa 2014-02-12 09:38:40 UTC
Patch fixes it.
Now firefox, once started looks ugly with oxygen-gtk.
Pretty much because it gets ported as poorly as it was with gtk2, and this will require as many hacks and fixes as there was in gtk2 ... 
I'm depressed.
Comment 5 Hugo Pereira Da Costa 2014-02-17 12:52:40 UTC
Git commit 30d2bad2bc18bc7859ee2316b7548704fed00b0e by Hugo Pereira Da Costa.
Committed on 12/02/2014 at 09:35.
Pushed by hpereiradacosta into branch 'gtk3'.

Only register menubar to animation engine if the widget is actually valid.

M  +18   -11   src/oxygenthemingengine.cpp

http://commits.kde.org/oxygen-gtk/30d2bad2bc18bc7859ee2316b7548704fed00b0e
Comment 6 Hugo Pereira Da Costa 2014-02-25 08:57:27 UTC
*** Bug 331475 has been marked as a duplicate of this bug. ***
Comment 7 Sérgio Basto 2014-02-26 18:56:05 UTC
 (In reply to comment #6)
> *** Bug 331475 has been marked as a duplicate of this bug. ***

I provide the backtrace of the crash  following 
http://fedoraproject.org/wiki/Debugging_guidelines_for_Mozilla_products#Application_crash
Comment 8 Hugo Pereira Da Costa 2014-03-11 08:39:01 UTC
This is fixed in latest version of oxygen-gtk3 (from git).
Also fixed are several (though not all) rendering issues.
So closing.
I'll fix the remaining rendering issue once firefox-beta 'stabilizes'