Bug 330580 - [Patch] Add support for Unity quicklists to Konsole
Summary: [Patch] Add support for Unity quicklists to Konsole
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL: https://git.reviewboard.kde.org/r/115...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-30 14:10 UTC by Ivo Anjo
Modified: 2014-02-17 14:56 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivo Anjo 2014-01-30 14:10:56 UTC
This patch adds support for the quicklists feature of Unity, as per the freedesktop.org "Desktop
Entry Specification".

With this patch, a new action is added "Open a New Window" which is very useful when konsole is
used in Unity, as it allows you to create a new window without having to use menus or keyboard
shortcuts.

Gnome-terminal also includes similar support, and also Firefox. I basically copied the Firefox
desktop entry, as it already had translations of this action for a bunch of languages.

My main motivation for this is that I've always had the habit of using the best-of-breed applications on my desktop, regardless of the environment. So when I'm using KDE or Unity or XFCE I always use firefox, gajim, konsole, kate, gnote, ...
This is a small extra for Unity users, and has no drawbacks for other users, so I'd love to see this upstream.

Reproducible: Always
Comment 1 Ivo Anjo 2014-01-30 14:12:09 UTC
Patch added on reviewboard: https://git.reviewboard.kde.org/r/115400/
Comment 2 Kurt Hindenburg 2014-02-04 15:18:23 UTC
Git commit 4ef99992da2a409967160048696283541a8e7dfe by Kurt Hindenburg.
Committed on 04/02/2014 at 15:06.
Pushed by hindenburg into branch 'master'.

Add support for Unity quicklist

Thanks to Ivo Anjo knuckles@gmail.com

The translations are not included - we'll let them get translated the
normal KDE way.

Please verify this works as I don't have a way of testing.

REVIEW: 115400

M  +6    -0    desktop/konsole.desktop

http://commits.kde.org/konsole/4ef99992da2a409967160048696283541a8e7dfe
Comment 3 Kurt Hindenburg 2014-02-07 14:33:26 UTC
Git commit b18b1b306fc1adb6c8a32363669d82a7355ca485 by Kurt Hindenburg.
Committed on 04/02/2014 at 15:06.
Pushed by hindenburg into branch 'frameworks'.

Add support for Unity quicklist

Thanks to Ivo Anjo knuckles@gmail.com

The translations are not included - we'll let them get translated the
normal KDE way.

Please verify this works as I don't have a way of testing.

REVIEW: 115400
(cherry picked from commit 4ef99992da2a409967160048696283541a8e7dfe)

M  +6    -0    desktop/konsole.desktop

http://commits.kde.org/konsole/b18b1b306fc1adb6c8a32363669d82a7355ca485
Comment 4 Ivo Anjo 2014-02-13 10:52:28 UTC
(In reply to comment #3)
> Please verify this works as I don't have a way of testing.

Sorry, I forgot to reply, but I can confirm it's working nicely, thanks!

And thanks for committing this. I was actually sitting on it for a long time, manually adding it to all my machines because I thought it might not be acceptable upstream -- I've had some bad experiences before with small should-go-in-directly-but-are-ignored patches. Thanks!
Comment 5 Kurt Hindenburg 2014-02-15 18:09:49 UTC
It seems that in the latest desktop spec this has been removed

https://bugs.freedesktop.org/show_bug.cgi?id=66712
http://lists.freedesktop.org/archives/xdg/2013-July/012835.html

desktop/konsole.desktop: key "OnlyShowIn" in group "Desktop Action NewWindow" is deprecated
Comment 6 Ivo Anjo 2014-02-15 19:06:48 UTC
(In reply to comment #5)
> It seems that in the latest desktop spec this has been removed
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=66712
> http://lists.freedesktop.org/archives/xdg/2013-July/012835.html
> 
> desktop/konsole.desktop: key "OnlyShowIn" in group "Desktop Action
> NewWindow" is deprecated

I copied from the ones Firefox had. But I don't think removing that key would have any issues, the rationale seems to make sense.
Comment 7 Kurt Hindenburg 2014-02-16 23:53:37 UTC
Git commit 4b69f9125a7e0f6ac9f014a49047b17dc0db196d by Kurt Hindenburg.
Committed on 16/02/2014 at 23:52.
Pushed by hindenburg into branch 'master'.

Remove OnlyShowIn as it is depreciated in the latest desktop spec

M  +0    -1    desktop/konsole.desktop

http://commits.kde.org/konsole/4b69f9125a7e0f6ac9f014a49047b17dc0db196d
Comment 8 Kurt Hindenburg 2014-02-17 14:56:55 UTC
Git commit 4e323d11475aea3000b218e8eaf761acb5859732 by Kurt Hindenburg.
Committed on 16/02/2014 at 23:52.
Pushed by hindenburg into branch 'frameworks'.

Remove OnlyShowIn as it is depreciated in the latest desktop spec
(cherry picked from commit 4b69f9125a7e0f6ac9f014a49047b17dc0db196d)

M  +0    -1    desktop/konsole.desktop

http://commits.kde.org/konsole/4e323d11475aea3000b218e8eaf761acb5859732