Bug 330398 - Clock shows 59:59 upon time running out
Summary: Clock shows 59:59 upon time running out
Status: RESOLVED FIXED
Alias: None
Product: knights
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.5.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Alexander Semke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-25 16:21 UTC by Dave Kaye
Modified: 2016-01-10 13:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 2.6.0
Sentry Crash Report:


Attachments
Patch for bug 330398 (1.10 KB, patch)
2014-01-25 16:23 UTC, Dave Kaye
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Kaye 2014-01-25 16:21:35 UTC
The player timer clock displays 00:00 then 59:59 upon time running out.  Timer gives extra ticks below zero as system is being stopped, which is automatically passed to the game clock display. A property of QTimer is that it resets back to 24 hours upon passing backwards through zero.  If the full timer string is displayed the value is 23:59:59.  Mask this effect by setting the clock to a permanent value of 00:00 upon game end when time runs out.

Code is in gamemanager.cpp.

May be system cpu/graphics speed dependent.


Reproducible: Always

Steps to Reproduce:
1.Select any game type and allow time to run out for a player
2.
3.


Expected Results:  
Clock should stay at 0:00
Comment 1 Dave Kaye 2014-01-25 16:23:17 UTC
Created attachment 84838 [details]
Patch for bug 330398
Comment 2 Alexander Semke 2016-01-10 13:59:16 UTC
Fixed with 9faffa85ae7df549834b19059d13f59433ebd33f