Bug 330035 - On upgrade from 4.11.3 to 4.11.5 ability to set Windows Decoration Background Style lost (or moved?)
Summary: On upgrade from 4.11.3 to 4.11.5 ability to set Windows Decoration Background...
Status: RESOLVED WORKSFORME
Alias: None
Product: Oxygen
Classification: Plasma
Component: win deco (other bugs)
Version First Reported In: 4.11.5
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL: http://ubuntuforums.org/showthread.ph...
Keywords:
: 330655 331382 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-16 14:32 UTC by Marco Parillo
Modified: 2023-02-12 03:50 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot showing differences in window decoration between firefox and chrome (515.26 KB, image/png)
2014-01-29 20:19 UTC, Thiago Oliveira
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Parillo 2014-01-16 14:32:41 UTC
Hey I am running Kubuntu 13.10 and just received the upgrade for 4.11.5. I noticed after the upgrade under the Window Decoration options for Oxygen that under the Fine Tuning and Window Override options, the ability to select Background Style is gone.. it allowed you to change the title bar from "follow hint style", "radial gradient", and "solid color".

From: http://ubuntuforums.org/showthread.php?t=2199536

Reproducible: Always
Comment 1 Hugo Pereira Da Costa 2014-01-16 16:05:50 UTC
The option has actually been replaced by 
[Common]
UseBackgroundGradient=true

(or false)

in $HOME/.kde(4)/share/config/oxygenrc

in order to fix another bug report.
This one enables/disables the window gradient in both oxygen decoration and style.
Now, due to string freeze, I could not add an UI element in the configuration dialog. 

Also, yes the ability to have a 'per application' setting for this option was lost in the process (because the above option acts on the widget style, not on the decoration), but on the other hand, the "follow style hint" should be enough to detect whether a background gradient is needed or not depending on whether one is drawn in the main window. For instance, here at least, the decoration has no gradient for chrome, since none is drawn in the main window.

I'd be interested in getting the list of applications that would trigger "false positives" as it would be a "bug" in the widget style implementation (e.g. oxygen-gtk).
Comment 2 Hugo Pereira Da Costa 2014-01-16 16:06:40 UTC
(here, firefox, thunderbird and other gtk apps also don't have 'automatically' any background gradient)
Comment 3 Thiago Oliveira 2014-01-22 14:54:02 UTC
I'm using Arch linux with kde-workspace 4.11.5 and google-chrome and chromium show a radial gradient and it doesn't match the solid background of the tab bar. Without the ability to create custom rules I can't correct this!
Comment 4 exzemat 2014-01-26 15:23:46 UTC
"I'd be interested in getting the list of applications that would trigger "false positives" as it would be a "bug" in the widget style implementation (e.g. oxygen-gtk)."
libreoffice (without libreoffice-kde4) is buggy with UseBackgroundGradient=false 
http://pix.toile-libre.org/upload/original/1390749636.png
Comment 5 Hugo Pereira Da Costa 2014-01-26 15:42:45 UTC
@exzemat
Ca reproduce.
Will investigate.
(PS separate bug would have been better, but so is ok)
Comment 6 Hugo Pereira Da Costa 2014-01-26 16:01:20 UTC
Git commit 05442b10ca9c9464d8153608e18bc065297a239e by Hugo Pereira Da Costa.
Committed on 26/01/2014 at 16:00.
Pushed by hpereiradacosta into branch '1.4'.

Properly set cliprect when rendering background with "useBackgroundGradient" set to false.

M  +14   -2    src/oxygenstyle.cpp

http://commits.kde.org/oxygen-gtk/05442b10ca9c9464d8153608e18bc065297a239e
Comment 7 exzemat 2014-01-29 19:18:46 UTC
(In reply to comment #3)
> I'm using Arch linux with kde-workspace 4.11.5 and google-chrome and
> chromium show a radial gradient and it doesn't match the solid background of
> the tab bar. Without the ability to create custom rules I can't correct this!

Me too !
it's not possible to create some rules in some txt.conf, wainting for the resolution in UI ?

@ Hugo
Sorry, for the next, I will created new bug.
Comment 8 Hugo Pereira Da Costa 2014-01-29 20:01:33 UTC
Could you post a screenshot of your chromium-browser ? 
Mine has no gradient what so ever in the window content, and (accordingly, as it should), no gradient either in the window decoration.

Also could you do an "xprop |& grep -i oxygen" and select the window which has inconsistent look (chromium) ? 
I would expect it to return nothing. 
If on the other hand a gradient is shown in the decoration, I would expect something like:
_KDE_OXYGEN_BACKGROUND_GRADIENT(CARDINAL) = 1

which, in turn, would be incorrect (and should be investigated), and responsible for the inconsistency.

Final question: you guys are using oxygen (not oxygen-transparent) as a window decoration. Correct ?
Comment 9 Hugo Pereira Da Costa 2014-01-29 20:02:29 UTC
PS: my google chrome (all flat): http://wstaw.org/m/2014/01/29/plasma-desktopkK5236.png
Comment 10 Thiago Oliveira 2014-01-29 20:19:34 UTC
Created attachment 84886 [details]
screenshot showing differences in window decoration between firefox and chrome

This is my google chrome (wrong gradient) and firefox (flat) with oxygen decoration in KDE 4.12.1 in my archlinux.
Comment 11 exzemat 2014-01-29 20:33:42 UTC
"xprop |& grep -i oxygen" no return when select chromium, firefox or libreoffice
But you right, chromium is all flat, 

I've only inconsistent look with chrome by google (need it for flashpepper) and firefox themed (with http://oxygenkde.altervista.org/); and with libreoffice (with oxygen-gtk) as you have see on my first screenshoot
http://pix.toile-libre.org/upload/original/1391026166.png

"xprop |& grep -i oxygen" return after select chrome by google
_KDE_OXYGEN_BACKGROUND_GRADIENT(CARDINAL) = 1

And yes, I use oxygen as windows decoration (no oxygen transparent)
Comment 12 Hugo Pereira Da Costa 2014-01-29 20:43:14 UTC
@exzemat
ok. For firefox, makes sense. The "theme" draws a gradient, that the decoration does not catch.
Would you use unthemed firefox (e.g. native oxygen-gtk), all would be flat ... 
I agree that for this, an "exception" would be required. But then, there is no guarantee that the firefox's theme gradient does actually match the one drawn by the decoration (I'm pretty sure it will; has to; break at some point in the future).

For libreoffice, I see that too, and am investigating. This is definitly a bug (background gradient is rendered, but the flag is not set), in oxygen-gtk. I guess it is the same for google chrome, but have no clue how to test. Where can I get/download/install google chrome ? (as opposed to chromium-browser, which I already have) ?

@Thiago
Very strange. Could you try the "xprop" thing ?
Comment 13 exzemat 2014-01-29 21:16:19 UTC
you can download .deb or .rpm
https://www.google.com/intl/fr/chrome/browser/

I use arch and chrome (by google) is available via aur
https://aur.archlinux.org/packages/google-chrome/

for firefox, you probably right, but this theme (http://oxygenkde.altervista.org/) is the only solution to make consistent with native kde look.
I will tell to the developper to see this tread. I think it's important for here theme.
Comment 14 Hugo Pereira Da Costa 2014-01-29 21:27:08 UTC
(In reply to comment #13)
> you can download .deb or .rpm
> https://www.google.com/intl/fr/chrome/browser/
> 

Interesting. I downloaded google chrome directly from there, and cannot reproduce the issue
(see: http://wstaw.org/m/2014/01/29/plasma-desktopeB5236.png)

Also there are other issues in the screenshot you have (the navigation bar), that I don't see. 
What version are you using ? is it unthemed ? (using gtk+ style) ? with oxygen-gtk as widget style ? And which version of oxygen-gtk ? 

> I use arch and chrome (by google) is available via aur
> https://aur.archlinux.org/packages/google-chrome/
> 
> for firefox, you probably right, but this theme
> (http://oxygenkde.altervista.org/) is the only solution to make consistent
> with native kde look.

Well, no ;)
Oxygen-gtk is supposed to make it consistent too (with _no_ theme in firefox).
Except for the window gradient.
See screenshot (my firefox):

http://wstaw.org/m/2014/01/29/plasma-desktopYl5236.png

Think it looks ok.

> I will tell to the developper to see this tread. I think it's important for
> here theme.
Comment 15 Hugo Pereira Da Costa 2014-01-30 16:31:11 UTC
Git commit 5b7f656ed34d60594282d3e98ee9d6b226966fc8 by Hugo Pereira Da Costa.
Committed on 30/01/2014 at 16:28.
Pushed by hpereiradacosta into branch '1.4'.

Re-enable "BackgroundHintEngine" for libreoffice
That ensures that window decoration gets the right background gradient, that matches the window contents

M  +2    -1    src/oxygenstylewrapper.cpp

http://commits.kde.org/oxygen-gtk/5b7f656ed34d60594282d3e98ee9d6b226966fc8
Comment 16 Hugo Pereira Da Costa 2014-01-30 16:34:11 UTC
... so libreoffice is fixed. Background gradient is back (when using oxygen-gtk), without a need for an exception.
one down. Some more to go
Comment 17 exzemat 2014-01-30 20:43:09 UTC
(In reply to comment #14)
> What version are you using ? is it unthemed ? (using gtk+ style) ? 
yes, unthemed, I'm using just gtk style
> with oxygen-gtk as widget style ? And which version of oxygen-gtk ? 
My oxygen-gtk2 : 1.4.3-1
oxygen-gtk3 :  1.3.3-1 

> Well, no ;)
> Oxygen-gtk is supposed to make it consistent too (with _no_ theme in
> firefox).
> Except for the window gradient.
> See screenshot (my firefox):
> 
> http://wstaw.org/m/2014/01/29/plasma-desktopYl5236.png
> 
> Think it looks ok.
My firefox look ok when I don't use this style (as you).
firefox is "consistent compared to himself" (windows decoration and widget)
But When I say that this theme "is the only solution to make consistent with native kde look"
I would say that is the only solution to make firefox consistent with native kde application, which have gradient...
but I understand your answer ;-)
the windows decorator's job is not to be consistent with firefox's theme

grat job job for libreoffice
I will test this commit as soon as possible
Comment 18 Ruslan Kabatsayev 2014-02-21 13:55:51 UTC
*** Bug 330655 has been marked as a duplicate of this bug. ***
Comment 19 Ruslan Kabatsayev 2014-02-21 13:56:04 UTC
*** Bug 331382 has been marked as a duplicate of this bug. ***
Comment 20 Andrew Crouthamel 2018-11-11 04:29:03 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 21 Andrew Crouthamel 2018-11-21 04:47:12 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 22 Justin Zobel 2023-01-13 01:36:32 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 23 Bug Janitor Service 2023-01-28 05:08:40 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 24 Bug Janitor Service 2023-02-12 03:50:32 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!