Bug 330034 - Debian kfreebsd fails to compile the acl support
Summary: Debian kfreebsd fails to compile the acl support
Status: RESOLVED NOT A BUG
Alias: None
Product: kio
Classification: Unmaintained
Component: general (show other bugs)
Version: 4.11.5
Platform: Debian unstable Other
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 13:38 UTC by Maximiliano Curia
Modified: 2018-05-03 20:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maximiliano Curia 2014-01-16 13:38:21 UTC
Hi,

Debian kfreebsd is a system that runs the gnu stack on top of the freebsd kernel, so things like Q_OS_FREEBSD, which are commonly used to detect a Freebsd kernel, are not defined. But,
__FreeBSD_kernel__ is.

In particular, kio/kfile/kpropertiesdialog.cpp static bool fileSystemSupportsACL( const QByteArray& path ) at line 1896, checks for #ifdef Q_OS_FREEBSD while it should check for #ifdef __FreeBSD_kernel__, as it's using the kernel api.
Also, note that it needs to include the additional headers:
// This is the *BSD branch
#ifdef HAVE_SYS_MOUNT_H
#ifdef HAVE_SYS_PARAM_H
#include <sys/param.h>
#endif
#include <sys/mount.h>
#endif

Thanks,



Reproducible: Always
Comment 1 Nate Graham 2018-05-03 20:41:26 UTC
The Debian variant in question has been discontinued, so this is no longer relevant or needed.