Bug 329980 - get rid of Workspace::sendClientToScreen() wrapper
Summary: get rid of Workspace::sendClientToScreen() wrapper
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: core (show other bugs)
Version: git master
Platform: unspecified Linux
: NOR task
Target Milestone: 5
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-14 22:19 UTC by Thomas Lübking
Modified: 2024-06-07 00:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Lübking 2014-01-14 22:19:20 UTC
one will have to open an editor and change the occurrences to call Client::sendToScreen()

Reproducible: Always
Comment 1 Thiago Sueto 2020-11-22 03:20:24 UTC
I've just grepped all occurrences of this in KWin. So I'm guessing this is still relevant.

grep -n -r "sendClientToScreen" .

./xdgshellclient.cpp:1568:                workspace()->sendClientToScreen( this, currentScreen );
./workspace.cpp:1252:void Workspace::sendClientToScreen(AbstractClient* c, int screen)
./x11client.cpp:4636:            workspace()->sendClientToScreen(this, currentScreen);
./rules.cpp:858:    workspace()->sendClientToScreen(this, screen());
./workspace.h:292:    void sendClientToScreen(AbstractClient* c, int screen);
./abstract_client.cpp:1002:        workspace()->sendClientToScreen(this, screen()); // checks rule validity
./useractions.cpp:775:    Workspace::self()->sendClientToScreen(m_client.data(), screen);
./useractions.cpp:1200:            sendClientToScreen(active_client, i);
./useractions.cpp:1208:        sendClientToScreen(active_client, (active_client->screen() + 1) % screens()->count());
./useractions.cpp:1214:        sendClientToScreen(active_client, (active_client->screen() + screens()->count() - 1) % screens()->count());
./scripting/workspace_wrapper.cpp:360:void WorkspaceWrapper::sendClientToScreen(AbstractClient *client, int screen)
./scripting/workspace_wrapper.cpp:365:    workspace()->sendClientToScreen(client, screen);
./scripting/workspace_wrapper.h:336:    void sendClientToScreen(KWin::AbstractClient *client, int screen);
./effects.cpp:923:        Workspace::self()->sendClientToScreen(cl, screen);
./placement.cpp:666:        workspace()->sendClientToScreen(this, screen()); // checks rule validity
./activation.cpp:832:        workspace()->sendClientToScreen(this, asn_data.xinerama());

The only occurrence of a full match of Workspace::sendClientToScreen is
./workspace.cpp:1252:void Workspace::sendClientToScreen(AbstractClient* c, int screen)
Comment 2 Bug Janitor Service 2024-06-06 15:30:02 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5847
Comment 3 Zamundaaa 2024-06-07 00:55:39 UTC
Git commit bffae4198391c67e18b56ed274147a35294ea905 by Xaver Hugl.
Committed on 07/06/2024 at 00:44.
Pushed by zamundaaa into branch 'master'.

remove Workspace::sendWindowToOutput

It just calls Window::sendToOutput...

M  +6    -6    autotests/integration/xdgshellwindow_rules_test.cpp
M  +2    -2    autotests/integration/xdgshellwindow_test.cpp
M  +1    -1    src/effect/effecthandler.cpp
M  +1    -1    src/placement.cpp
M  +1    -1    src/scripting/workspace_wrapper.cpp
M  +8    -8    src/useractions.cpp
M  +2    -2    src/window.cpp
M  +0    -5    src/workspace.cpp
M  +0    -1    src/workspace.h
M  +1    -1    src/x11window.cpp

https://invent.kde.org/plasma/kwin/-/commit/bffae4198391c67e18b56ed274147a35294ea905