Bug 329639 - SGR color codes should support colon as separator
Summary: SGR color codes should support colon as separator
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: emulation (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 01:17 UTC by Egmont Koblinger
Modified: 2022-11-03 12:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: v22.08.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Egmont Koblinger 2014-01-06 01:17:05 UTC
doc/user/README.moreColors (in konsole's source) says:
"The separator character 03/10 they use is a colon, not a semicolon... I wonder 
if the xterm implementation was based on an improper reading of the standard?"

Indeed, it was a bug in xterm, fixed in patch #282. Also, iterm2 added support for colon separator: https://code.google.com/p/iterm2/issues/detail?id=218

SGR escape sequences that set a 256-palette color (38/48;5;index) or a true color (38/48;2;red;green;blue) should also accept colon as the separator (according to the standard), in addition to the buggy-by-design semicolon (for compatibility with older xterm and with terminfo entries for 256 colors).

Reproducible: Always

Steps to Reproduce:
$ echo -e '\e[38;5;100;48;2;40;60;80mabcdef'
$ echo -e '\e[38:5:100;48:2:40:60:80mabcdef'

Actual Results:  
First one works, second one doesn't.

Expected Results:  
Second one should do the same as the first.
Comment 1 Egmont Koblinger 2014-01-06 18:17:01 UTC
Additional info/discussions in bug 107487, and in xterm's charproc.c near parse_extended_colors().
Comment 2 Kurt Hindenburg 2014-01-11 20:36:59 UTC
Thanks - at first glance this doesn't appear to be trivial to fix.
Comment 3 Egmont Koblinger 2014-01-11 21:46:49 UTC
Here's the gnome-terminal counterpart, yup, it's not trivial to fix there either.
https://bugzilla.gnome.org/show_bug.cgi?id=685759
Comment 4 ratijas 2020-10-03 15:23:39 UTC
Steps to reproduce are still reproducible today.

I wonder, should it be fixed at all?