Bug 329557 - Smudge Rate controls the opacity of the final dab, not of the picked background, which results in nothing being painted when Smudge Rate is 0.
Summary: Smudge Rate controls the opacity of the final dab, not of the picked backgrou...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 2.8 Beta
Platform: unspecified Other
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-03 11:06 UTC by Bollebib
Modified: 2014-01-06 10:32 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot : Krita SmudgeRate (top) ; Mypaint SmudgeLength (bottom) (459.61 KB, image/png)
2014-01-05 16:28 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2014-01-03 11:06:35 UTC
Smudge Rate controls the opacity of the final dab, not of the picked background, which results in nothing being painted when Smudge Rate is 0.


11:50:06 - Bollebib1: dmitryK: incidently I'm testing a smudge brush but i see no color rate being added,even tho it's up to a 100
11:50:20 - Bollebib1: have there been recen changes,and do I need to update?
11:50:33 - dmitryK: not actually. master?
11:50:44 - Bollebib1: 2.8 beta
11:50:54 - Bollebib1: but I might be mistaken in my settings ofc..
11:51:09 - Bollebib1: ah
11:51:15 - Bollebib1: opacity was perhazps too low
11:51:17 - Bollebib1: let me check

11:52:07 - dmitryK: Bollebib1: seems like if the Dulling Mode slider is at 0, the brush isn't painting anything, which is actually a bug

11:52:37 - dmitryK: Bollebib1: but it starts painting when you raise the Dulling Mode slider a bit

Reproducible: Always
Comment 1 animtim 2014-01-03 12:09:33 UTC
A few infos on this topic:
-This has always worked this way (so if really a bug, it's always been there)

-This is not specific to Dulling mode, it does the same for Smearing mode.

-I remember I thought about this when working on the color smudge presets, and in the end I think it's not really a bug, as Smudge Rate controls the global "quantity of smudge" and color rate controls how much selected-color is added/mixed in this smudge.. I believe that having it working another way would not allow the same brush effect as we have currently.
And so if I need a brush without smudge at all (which I guess would be what you expect of a brush with max.smudge set to 0 as described in this case), better use a pixel brush which will have more options and probably more optimised performances.
Comment 2 David REVOY 2014-01-05 15:21:38 UTC
Yes, actual 'Smudge Rate' slider affect final dab this way. As Animtim said, this is not really a bug. Just the design of the brush engine 'as it is now'.

The expectation of Bollebib is probably to have more control in the 'amount of Smudge' or 'Smudge Power' , 'Smudge Lenght' ?  Something the actual 'Smudge Rate' can't obviously do. This is a legit observation of the limitation of the current system. But definitely a [Wish]  ( not a bug ) . And it will need documentations and references to describe the desired effect.
Comment 3 David REVOY 2014-01-05 16:28:34 UTC
Created attachment 84465 [details]
Screenshot : Krita SmudgeRate (top)  ;  Mypaint SmudgeLength (bottom)

After a bit of research ( attachement ) ; it appears 2 possible fix : 

1) Label : 
========
"krita Smudge Rate" = "mypaint Smudge Length" ( attachement ). So, for consistency in the label , renaming 'Smudge Rate' to 'Smudge Length' sounds better. 

2) The 0.00 non effect should be non-possible
======================================
 The slider should prevent user to do a 'non stroke' by making not accessible 0.00 value. ( ex; by making 0 behave as actual 0.01 ).
Comment 4 Halla Rempt 2014-01-06 10:04:47 UTC
Git commit 4d4608e50ae7433e12544b71b332bd7377ea5c15 by Boudewijn Rempt.
Committed on 06/01/2014 at 10:03.
Pushed by rempt into branch 'calligra/2.8'.

And set the minimum value of the smudge length to 0.1

M  +1    -1    krita/plugins/paintops/colorsmudge/kis_colorsmudgeop_settings_widget.cpp
M  +4    -1    krita/plugins/paintops/colorsmudge/kis_smudge_option.cpp

http://commits.kde.org/calligra/4d4608e50ae7433e12544b71b332bd7377ea5c15
Comment 5 Halla Rempt 2014-01-06 10:04:57 UTC
Git commit 62529fba596a99555c2373ad790d0042057083ad by Boudewijn Rempt.
Committed on 06/01/2014 at 10:03.
Pushed by rempt into branch 'master'.

And set the minimum value of the smudge length to 0.1

M  +1    -1    krita/plugins/paintops/colorsmudge/kis_colorsmudgeop_settings_widget.cpp
M  +4    -1    krita/plugins/paintops/colorsmudge/kis_smudge_option.cpp

http://commits.kde.org/calligra/62529fba596a99555c2373ad790d0042057083ad
Comment 6 David REVOY 2014-01-06 10:32:46 UTC
Hi Boud, Thanks for the commit above :) 
I noticed a little typo in the commit ;  "Set the minimum value of the smudge length to 0.1" should not be 0.1 but 0.01 ; there is still room for interresting effect within the 0.01 to 0.10 range of smudge length.