If I have a picture with no Tags but with Labels, the 'Remove Tag' menu entry in Context Menu stayed enabled until I hover the mouse pointer over this menu entry. Reproducible: Always Steps to Reproduce: 1-Make sure that this picture has no Tag 2-Assign a Label 3-Right-click on this picture ('Remove Tag' menu entry is enabled) 4-Go to 'Remove Tag' menu entry Expected Results: Don't enable menu entry if the picture has no Tags.
Already implemented in 4.0.0-beta2 Gilles Caulier
(In reply to comment #1) > Already implemented in 4.0.0-beta2 > > Gilles Caulier I can still reproduce this bug on digikam 4.0
I can still reproduce this bug on digikam 4.11 Watch this screencast: https://youtu.be/gz0BdA24B9g
As i can see on screencast, the menu entry is not disabled at menu showEvent(), but only when mouse is over menu option. So, the disabling process must be done when menu is populated, just before to show it. Gilles
Created attachment 93516 [details] contextmenu.patch This patch checks if only color or pick label tags in the selected images are. Maik
Just tested. Patch work fine here... Gilles
Git commit 2426e9f6cbd150455e743e54cbc204f97ae47101 by Maik Qualmann. Committed on 07/07/2015 at 18:50. Pushed by mqualmann into branch 'master'. apply patch #93516 to disable "Remove Tag" context menu if only color or pick label tags are present FIXED-IN: 4.12.0 M +2 -1 NEWS M +16 -2 app/utils/contextmenuhelper.cpp http://commits.kde.org/digikam/2426e9f6cbd150455e743e54cbc204f97ae47101
Git commit b5badd9b0500f539dda24f85b052c9d1242ba85d by Maik Qualmann. Committed on 07/07/2015 at 20:04. Pushed by mqualmann into branch 'master'. check also for internal tags to disable context menu M +2 -1 app/utils/contextmenuhelper.cpp http://commits.kde.org/digikam/b5badd9b0500f539dda24f85b052c9d1242ba85d
Git commit dee6477cec8aef873798011bec5598ebda7befd1 by Gilles Caulier. Committed on 07/07/2015 at 21:00. Pushed by cgilles into branch 'frameworks'. backport commit #2426e9f6cbd150455e743e54cbc204f97ae47101 from git/master to frameworks branch M +17 -3 app/utils/contextmenuhelper.cpp http://commits.kde.org/digikam/dee6477cec8aef873798011bec5598ebda7befd1
Git commit b56d3002085d689b9cb8e0bc707d67f3964fc2a0 by Gilles Caulier. Committed on 07/07/2015 at 21:02. Pushed by cgilles into branch 'frameworks'. backport commit #b5badd9b0500f539dda24f85b052c9d1242ba85d from git/master to frameworks branch M +2 -1 app/utils/contextmenuhelper.cpp http://commits.kde.org/digikam/b56d3002085d689b9cb8e0bc707d67f3964fc2a0