Bug 328830 - Digikam compile error because of commit f3e488b56e4d56be0bb1022e32258add72c3c68a
Summary: Digikam compile error because of commit f3e488b56e4d56be0bb1022e32258add72c3c68a
Status: CLOSED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: 4.0.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-15 11:30 UTC by Kristian Karl
Modified: 2017-08-19 20:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Karl 2013-12-15 11:30:18 UTC
Compile error because of commit f3e488b56e4d56be0bb1022e32258add72c3c68a

CMakeFiles/showfoto.dir/thumbbar/showfotocategorizedview.cpp.o: In function `ShowFoto::ShowfotoCategorizedView::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)':
/home/krikar/dev/kde/digikam/build/core/showfoto/showfotocategorizedview.moc:90: undefined reference to `ShowFoto::ShowfotoCategorizedView::slotShowfotoItemInfosAdded()'
collect2: error: ld returned 1 exit status
make[2]: *** [core/showfoto/showfoto] Error 1
make[1]: *** [core/showfoto/CMakeFiles/showfoto.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....


Reproducible: Always

Steps to Reproduce:
Compile latest from master.

The code compile if following patch is applied:

============== START OF PATCH============
diff --git a/showfoto/thumbbar/showfotocategorizedview.h b/showfoto/thumbbar/showfotocategorizedview.h
index 9c8474a..b9f8aea 100644
--- a/showfoto/thumbbar/showfotocategorizedview.h
+++ b/showfoto/thumbbar/showfotocategorizedview.h
@@ -154,9 +154,6 @@ Q_SIGNALS:
     /// Emitted when a new model is set
     void modelChanged();
 
-protected Q_SLOTS:
-
-    void slotShowfotoItemInfosAdded();
 
 protected:
 
============== END OF PATCH============
Comment 1 caulier.gilles 2013-12-15 13:19:45 UTC
Mohamed,

This file is for you...

Gilles Caulier
Comment 2 caulier.gilles 2013-12-15 20:58:58 UTC
Git commit 1982fb373ab087df1145b075912986b9bc81dbef by Mohamed Anwer.
Committed on 15/12/2013 at 18:32.
Pushed by mohamedanwer into branch 'master'.

Removing unwanted slot

M  +0    -4    showfoto/thumbbar/showfotocategorizedview.h

http://commits.kde.org/digikam/1982fb373ab087df1145b075912986b9bc81dbef

diff --git a/showfoto/thumbbar/showfotocategorizedview.h b/showfoto/thumbbar/showfotocategorizedview.h
index 9c8474a..140b689 100644
--- a/showfoto/thumbbar/showfotocategorizedview.h
+++ b/showfoto/thumbbar/showfotocategorizedview.h
@@ -154,10 +154,6 @@ Q_SIGNALS:
     /// Emitted when a new model is set
     void modelChanged();

-protected Q_SLOTS:
-
-    void slotShowfotoItemInfosAdded();
-
 protected:

     // reimplemented from parent class