Bug 328658 - Since okular-4.11 KFileDialog does not use "Recent Dirs"
Summary: Since okular-4.11 KFileDialog does not use "Recent Dirs"
Status: RESOLVED NOT A BUG
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-11 12:58 UTC by Eugeny Shkrigunov
Modified: 2013-12-14 11:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Eugeny Shkrigunov 2013-12-11 12:58:21 UTC 
Hi!
Sorry for my English.

There is regression in okular-4.11 and newer:
KFileDialog does not use "Recent Dirs" in "Save As" dialog
because of this change:
--- okular-4.10.5/part.cpp      2013-06-28 21:37:20.282808697 +0400
+++ okular-4.11.0/part.cpp      2013-07-23 13:01:24.000000000 +0400
@@ -2026,7 +2059,7 @@
         }
     }

-    KUrl saveUrl = KFileDialog::getSaveUrl( KUrl("kfiledialog:///okular/" + url().fileName()),
+    KUrl saveUrl = KFileDialog::getSaveUrl( url(),
                                             QString(), widget(), QString(),
                                             KFileDialog::ConfirmOverwrite );
     if ( !saveUrl.isValid() || saveUrl.isEmpty() )

Reverting this change fix the problem.

Reproducible: Always
Comment 1 Albert Astals Cid 2013-12-11 18:49:19 UTC 
Yes, that's a feature[1] and not a bug

[1]  BUG #319042
Comment 2 Eugeny Shkrigunov 2013-12-12 08:15:20 UTC 
(In reply to comment #1)
> Yes, that's a feature[1] and not a bug
> 
> [1]  BUG #319042

Take a look at the bug report #328703
Comment 3 Fabio D'Urso 2013-12-14 11:43:33 UTC 
All applications that I know always default to the location the file was opened from, and this seems to me the right thing to do:
 a) it is what most users expect (it is consistent with other applications) 
 b) it is more practical if you want to save over the current file (keep in mind that we currently lack a plain "save" button, even though this is more an excuse than a reason :P)

I've read bug 328703, but I'm not sure I understand why you don't agree with this new behaviour: you still have "Save Copy As" that behaves the other way.