Bug 328576 - Add keyboard shortcut for 'search previous' action: Shift+Enter
Summary: Add keyboard shortcut for 'search previous' action: Shift+Enter
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.17.2
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-12-09 14:47 UTC by Kevin Funk
Modified: 2014-03-04 00:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.13.0

Attachments
proposed patch (1.61 KB, patch)
2013-12-30 08:04 UTC, Saheb Preet Singh 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Funk 2013-12-09 14:47:34 UTC 
Nearly every application that I use provides that shortcut for jump to previous occurrences of a search string: Shift+Enter. Currently this is only possible by default via Shift+F3.

Would be cool to have this as a default in Okular, too.

Reproducible: Always
Comment 1 Albert Astals Cid 2013-12-09 16:04:21 UTC 
Patches welcome
Comment 2 Saheb Preet Singh 2013-12-30 08:04:53 UTC 
Created attachment 84341 [details]
proposed patch

The attached patch applies to the file ui/searchlineedit.cpp and ui/searchlineedit.h

Added a key event listener to the SearchLineEdit for shift+return.

i am new to kde please guide me if something is wrong
Comment 3 Albert Astals Cid 2013-12-30 12:09:49 UTC 
Hi, can you please put the patch up at https://git.reviewboard.kde.org/, it helps a lot with the reviewing
Comment 4 Albert Astals Cid 2014-03-04 00:08:45 UTC 
This was implemented in https://git.reviewboard.kde.org/r/114754/