Bug 328317 - Webkit ignores custom css
Summary: Webkit ignores custom css
Status: RESOLVED WORKSFORME
Alias: None
Product: kwebkitpart
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: webkit-devel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 08:52 UTC by j_kanev
Modified: 2023-02-09 03:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description j_kanev 2013-12-02 08:52:24 UTC
For the webkit view engine, custom css is ignored.

Most web designers are lazy and define either only foreground or only background colour, but not both (as they should). Using a dark theme I see web pages either white on white or black on black. Since KHtml is unusable with most more complex websites (OpenERP, Twitter, ...) I rely on the webkit engine when using konqueror.

Displaying unlegible web pages renders konqueror completely useless, even if the html is actually intepreted correctly. This is a shame, it has many nice features other browsers don't have.

Reproducible: Always

Steps to Reproduce:
1. Set your KDE system colours to white on black (i.e. any dark theme)

2. Create a custom css:html with following content:
     button,
     input,
     select,
     textarea,
     * {
             background-color: #ffffff;
             color: #000000;
     }

3. Create test file with following content: 
     <html><head></head><body>
     This is a text.<br>
     This is a toxt.<br>
     </body></html>

4. In the konqueror menu, activate Settings → Configure Konqueror → Appearance → Style Sheets → User Defined Style Sheet, and enter the name of the css file (from step 2).

5. Point your prowser to the html file (from step 3) and from the menu select View → View Mode → WebKit.

Actual Results:  
Black writing on black (or dark grey, depending on your theme) background.

Expected Results:  
Black writing on white background.

This doesn't happen with the KHtml engine.

When linking the css file into the html file directly a white background is shown, so css actually works and the css I used in the example is intepreted correctly by WebKit.

When disabling user defined css, the text is still seen black on black, allthough it should be white, as in the KDE system theme.
Comment 1 Dawit Alemayehu 2014-03-15 05:18:40 UTC
The issue of custom CSS definitions not working in kwebkitpart has been addressed a long time ago.  Which version of kpart-webkit is installed on your system?
Comment 2 j_kanev 2014-03-19 13:50:27 UTC
(In reply to comment #1)
> The issue of custom CSS definitions not working in kwebkitpart has been
> addressed a long time ago.  Which version of kpart-webkit is installed on
> your system?

Version 1.3~git20120518.9a111005-3.
This is the package from Debian Sid (unstable).

Regards, Jacob.
Comment 3 Dawit Alemayehu 2014-03-20 12:48:05 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > The issue of custom CSS definitions not working in kwebkitpart has been
> > addressed a long time ago.  Which version of kpart-webkit is installed on
> > your system?
> 
> Version 1.3~git20120518.9a111005-3.
> This is the package from Debian Sid (unstable).
> 
> Regards, Jacob.

Well then I do not know what to tell you then. The information you provided worked fine for me. I changed my KDE color to "Krita-dark" and tested the custom CSS you provided and it worked fine. Granted my default browser engine is set to "WebKit" and not "KHTML". So I did not have to do the View->View Mode part. Perhaps that is the problem? I dunno. I did not try it.
Comment 4 Andrew Crouthamel 2018-11-11 04:28:51 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Andrew Crouthamel 2018-11-21 04:38:41 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Justin Zobel 2023-01-10 01:52:06 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 7 Bug Janitor Service 2023-01-25 05:05:51 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2023-02-09 03:54:04 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!