Bug 328315 - KMail doesn´t save changes when the column order in the messagelist is changed
Summary: KMail doesn´t save changes when the column order in the messagelist is changed
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: message list (show other bugs)
Version: 4.14.0
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-02 08:30 UTC by stevie_75
Modified: 2015-04-05 15:37 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description stevie_75 2013-12-02 08:30:43 UTC
KMail 4.11.97 doesn´t save changes when the column (sender, date,  subject) succession in the income box where changed - reproducable: every time!
Comment 1 stevie_75 2014-09-07 18:54:53 UTC
This wasn´t the case in KMail 4.11. When changes in the succession of the columns (1. subject, 2. date, 3. sender name) where made (for example: 1. sender name, 2. date, 3. subject), by closing KMail and reopen it - changes are gone.

Solution: save succession of the columns.
Comment 2 stevie_75 2014-09-07 19:01:15 UTC
This wasn´t the case in KMail 4.11. When changes in the succession of the columns (1. subject, 2. date, 3. sender name) where made (for example: 1. sender name, 2. date, 3. subject), by closing KMail and reopen it - changes are gone. Solution: save succession of the columns.
Comment 3 kolAflash 2014-11-06 00:04:24 UTC
Reproducible with openSUSE Linux.

openSUSE 13.1 with KDE 4.11.5 still saved column succession/order and size of columns.

openSUSE 13.2 with KDE 4.14.2 forgets succession/order and size of columns.

Any updates on this bug-report?


It's very annoying for daily use of KMail.
I know, the column order can be changed by the "Message List" theme. But the column size can't.

Additionally I was used (in 4.11.5) to have a "Message List" theme with a message-column and a clickable status column (carrying icons for read/unread and important). In the theme, the status-column was configured to be on the right, because I wanted to have the message-tree (for message-thread groups) in the message column.
In KMail (not in the "Message List" theme editor) I moved that status column to the left. By that, the "tree" stayed at the message column. That's exactly the way I like it!
In general, this still possible. But after restarting KMail the status column is back at the right side :-(
Comment 4 kolAflash 2014-11-06 00:23:01 UTC
Just a guess (I'm not very experienced in the KMail sourcecode):


Is this the file responsible for the message-list in KMail?

https://projects.kde.org/projects/kde/kdepim/repository/revisions/v4.11.97/changes/messagelist/pane.cpp

If yes, the problem might be caused by any of the changed between git revision e2489368 (2013-08-11) and revision 7f9198c6 (2013-11-19)

https://projects.kde.org/projects/kde/kdepim/repository/diff/messagelist/pane.cpp?rev=7f9198c6710f2e1b05fd066ff6769db2f6a96cdb&rev_to=e2489368898cee4b4c908cbc0d8c20cf58bb4a7b
Comment 5 Laurent Montel 2014-11-06 06:52:29 UTC
I need more infos because column position is correctly stored here.
Comment 6 kolAflash 2014-11-06 12:52:57 UTC
Try Kubuntu 14.10 x86_64 with KDE-4.14.1

http://cdimage.ubuntu.com/kubuntu/releases/utopic/release/kubuntu-14.10-desktop-amd64.iso

Start the livecd, then start KMail. Don't set up an mail account. Just use "Local Folders".
On the first start KMail doesn't show a message list... don't know why. But on the second start the "Message List" is there. If you rearrange the order of the "Message" and "Status" columns, it won't last after closing and reopening KMail.


Same with openSUSE 13.2 x86_64 livecd.
(just need to switch to "Smart with Clickable Status" message-list theme before to get columns)

http://ftp4.gwdg.de/pub/opensuse/distribution/13.2/iso/openSUSE-13.2-KDE-Live-x86_64.iso


I'll see if I can get more information. Do you need anything specific?
Comment 7 stevie_75 2014-11-06 20:25:18 UTC
What infomation exacly do you need? Please specify and i´ll see if i can provide more infomation. Thank you in advance!
Comment 8 stevie_75 2014-11-06 20:51:17 UTC
Currently i am using the OpenSuse Tumbleweed Repos. Bug already exists. The bug didn´t exist with KDE 4.10.4 Release 5 and reappear with KDE 4.11.97.
Comment 9 David Faure 2014-11-07 08:00:48 UTC
I can reproduce the bug with 4.14 indeed:

Right-click on message-list headerview.
Check the "Unread" item to make that column appear.
Move it to column 0, before the Subject.
Quit KMail.
Launch KMail.
The Unread column is now on the right side of all other columns.
Comment 10 Laurent Montel 2014-11-07 08:36:10 UTC
David you will look at me next week because I tested it and it's stored.
So I can't reproduce it.

Thanks
Comment 11 kolAflash 2014-11-07 20:02:46 UTC
@Laurent Montel
This should be perfectly reproduceable for you:


Correct behavior:
Boot the Kubuntu 13.10 AMD64 livecd (including KDE 4.11.2) in VirtualBox (I used VirtualBox 4.3.18).
If you run KMail, everything should be fine! You can move columns in KMail, close KMail, reopen it and the columns should be right where you left them.

http://cdimage.ubuntu.com/kubuntu/releases/13.10/release/kubuntu-13.10-desktop-amd64.iso


Buggy behavior:
Boot the Kubuntu 14.04.1 AMD64 livecd (including KDE 4.13.2) in VirtualBox (I also used VirtualBox 4.3.18 for this).
If you run KMail, first you'll have to enable columns (View => Message List => Theme => Smart with Clickable Status).
Then you can move columns. But after closing and reopen KMail, it will put the columns back to their default positions (specified by the "Smart with Clickable Status" theme).

http://cdimage.ubuntu.com/kubuntu/releases/trusty/release/kubuntu-14.04.1-desktop-amd64.iso
Comment 12 David Faure 2014-11-09 16:19:12 UTC
Reproducing a bug with a live CD doesn't really help fixing it (this requires a compiled debug version). But anyway, I can reproduce it, so I'll debug it with Laurent next time we meet. Meanwhile, maybe a hint about where the code for loading/storing is? ;)
Comment 13 Laurent Montel 2014-11-10 12:18:52 UTC
Header from messagelist is stored here:
void Pane::writeConfig(bool restoreSession)

Restore here: "void Pane::readConfig(bool restoreSession)"
in messagelist/pane.cpp
Comment 14 Laurent Montel 2014-11-16 11:18:40 UTC
Git commit e54fd2e1250f0a4b6bb958ea46e26b69c4438fa4 by Montel Laurent.
Committed on 16/11/2014 at 11:18.
Pushed by mlaurent into branch 'KDE/4.14'.

Fix Bug 328315 - KMail doesn´t save changes when the column order in the messagelist is changed
FIXED-IN: 4.14.4

M  +5    -0    messagelist/pane.cpp

http://commits.kde.org/kdepim/e54fd2e1250f0a4b6bb958ea46e26b69c4438fa4
Comment 15 kolAflash 2014-11-17 09:53:59 UTC
> http://commits.kde.org/kdepim/e54fd2e1250f0a4b6bb958ea46e26b69c4438fa4
Works!

I tried the patch on the KDE 4.14.2 source-rpm of openSUSE 13.2.
http://download.opensuse.org/source/distribution/13.2/repo/oss/suse/src/kdepim4-4.14.2-1.1.src.rpm
Now column order and column size are properly restored after restarting KMail.
Comment 16 David Faure 2015-04-04 11:53:37 UTC
Reporter says the fix works -> closing.