Bug 328125 - Add "play/pause" button in "Presentation Mode"
Summary: Add "play/pause" button in "Presentation Mode"
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.16.5
Platform: Mint (Ubuntu based) Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL: http://www.23hq.com/0O-1/photo/146675...
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-11-26 22:05 UTC by uUn
Modified: 2014-02-24 22:36 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/okular/921815b58b80d569284dab53ce83f747aa295363
Version Fixed In: 4.13.0
Sentry Crash Report:

Attachments
File 1 for posterity (341.19 KB, image/png)
2013-11-26 22:29 UTC, Albert Astals Cid 		Details
File 2 for posterity (197.61 KB, image/png)
2013-11-26 22:31 UTC, Albert Astals Cid 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description uUn 2013-11-26 22:05:45 UTC 
when i enabled this section (http://www.23hq.com/0O-1/photo/14667535?)
I’d like to use this button (http://www.23hq.com/0O-1/photo/14667542?)

Reproducible: Always
Comment 1 Albert Astals Cid 2013-11-26 22:29:44 UTC 
Created attachment 83782 [details]
File 1 for posterity
Comment 2 Albert Astals Cid 2013-11-26 22:31:28 UTC 
Created attachment 83783 [details]
File 2 for posterity
Comment 3 Saheb Preet Singh 2014-01-16 09:14:14 UTC 
hi,

i just tried to implement the button and its working now. Here is a short explanation of what i did :-

Added a new action in part.cpp for play pause button.
Enabled the action in presentationwidget.cpp and added it to the topBar.
Finally connected the toggled signal to a new slot.
In that new slot when the signal is toggled on m_nextPageTimer is started and its singleShot is set to false, so that it starts playing the page.
when the signal is toggled off m_nextPageTimer is stopped and the singleShot is set to true.
Comment 4 Saheb Preet Singh 2014-01-16 09:16:57 UTC 
(In reply to comment #3)
> hi,
> 
> i just tried to implement the button and its working now. Here is a short
> explanation of what i did :-
> 
> Added a new action in part.cpp for play pause button.
> Enabled the action in presentationwidget.cpp and added it to the topBar.
> Finally connected the toggled signal to a new slot.
> In that new slot when the signal is toggled on m_nextPageTimer is started
> and its singleShot is set to false, so that it starts playing the page.
> when the signal is toggled off m_nextPageTimer is stopped and the singleShot
> is set to true.

Is it the correct way of implementation??? 

Also how will i get the play and pause button icon??

Sorry for the previous message, was posted incomplete by mistake.
Comment 5 Albert Astals Cid 2014-01-16 23:09:32 UTC 
Please submit the path to reviewboard, it's much easier discussing over actual code than over description of the code :-)
Comment 6 Albert Astals Cid 2014-02-24 22:30:28 UTC 
Git commit 921815b58b80d569284dab53ce83f747aa295363 by Albert Astals Cid, on behalf of Saheb Preet Singh.
Committed on 24/02/2014 at 21:39.
Pushed by aacid into branch 'master'.

Implement a play pause button in presentation mode

REVIEW: 115072
GUI

M  +4    -0    part.cpp
M  +34   -1    ui/presentationwidget.cpp
M  +2    -0    ui/presentationwidget.h

http://commits.kde.org/okular/921815b58b80d569284dab53ce83f747aa295363