Bug 327863 - PATCH: Magnifier proof of concept
Summary: PATCH: Magnifier proof of concept
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-20 13:44 UTC by howl
Modified: 2021-05-16 19:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Allow realy BIG pixmaps for document rendering (517 bytes, patch)
2013-11-20 13:45 UTC, howl
Details
Magnifying glass -- proof of concept (15.67 KB, patch)
2013-11-20 13:46 UTC, howl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description howl 2013-11-20 13:44:01 UTC
Hi there!

I realy missed the magnifying glass feature from the old kdvi, which comes very handy if you are doing typesetting. So I finaly told myself to hack it in and here comes the patch for it.

The 01-hack.patch is allowing the document to render big pixmaps for non tiled views. The rest is quite straightforward.

The magnifier can scroll the view "apropriately", doesn't fall of the edges and hovers correctly from one page to another.

So the remaining question is, what is the status of this:
 core/document_p.h:213  "// FIXME This is a hack, we need to support multiple tiled observers, but for the moment we only support one"
Is someone working on it?

Reproducible: Always
Comment 1 howl 2013-11-20 13:45:09 UTC
Created attachment 83653 [details]
Allow realy BIG pixmaps for document rendering
Comment 2 howl 2013-11-20 13:46:11 UTC
Created attachment 83654 [details]
Magnifying glass -- proof of concept
Comment 3 Albert Astals Cid 2013-11-20 18:04:28 UTC
reviewboard at https://git.reviewboard.kde.org/r/113973/
Comment 4 Oliver Sander 2015-03-17 16:26:37 UTC
I can't find the commit right now, but Okular nowadays does have a magnifying glass.  It's the 6th entry in the 'extras' menu.  Hence I propose to close this bug.
Comment 5 Laura David Hurka 2021-05-16 19:28:25 UTC
Oliver Sander 2015-03-17 16:26:37 UTC
> I can't find the commit right now, but Okular nowadays does have
> a magnifying glass.  It's the 6th entry in the 'extras' menu.
> Hence I propose to close this bug.
Done