Bug 327831 - Not all photos from addressbook shows using fancy headers
Summary: Not all photos from addressbook shows using fancy headers
Status: RESOLVED FIXED
Alias: None
Product: kmail2
Classification: Applications
Component: UI (show other bugs)
Version: 4.12 pre
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-19 20:25 UTC by luisfe
Modified: 2013-12-12 11:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description luisfe 2013-11-19 20:25:05 UTC
Irecently switched to fancy headers and noticed that not all photos presented in kaddressbook are showed. Some of the cases are reproducible

1) Some entries in kaddressbook (personal contacts) never shows the photo. I can confirm that the photo is in the nepomuk database.

2) If a contact has severl email addressed attached to it and I receive an email from that contact, then the photo only shows if the email address is the *standard address* of the contact. Any email from one of the other address do not show a picture.

3) If the same contact is duplicated in several resources, in my case a carddav resource (owncloud) and the "personal contacts resource", then the photo only appears if it is set in the carddav resource and the photo in the personal contact resource is just ignored.



Reproducible: Always

Steps to Reproduce:
1. Create a contact with two email address and a picture.
2. Configure kkmail with fancy headers.
3. Receive an email form the contact from one of the "non-standard" email address.
Actual Results:  
No picture is showed

Expected Results:  
The picture should appear.
Comment 1 Laurent Montel 2013-11-19 21:18:49 UTC
1) Can't comment about it. If it's in nepomuk it must displaying it (as it displays other picture)
2) I confirm it. I saw this bug yesterday, there is a pb when we add another email it's not all the time indexed don't know why.
3) pb is that we have several same contact so how define which picture shows ? I take the first one when we search so in your case the caldav result. If the two same contact has 2 differents pictures which picture I display ?
Comment 2 luisfe 2013-11-19 22:07:35 UTC
With respect to 2) I am not sure if it is a problem of not being indexed. If I change the default address, then the new default address shows the photo but the old default does not show the photo anymore.

Concerning 3), from a user perspective that knows little about programming, I would expect one of the following behaviors:

a) The system checks all the contacts containing the given email address until one with a photo is found. So it would show the first photo found, but if the firs contact does not have a photo will look for a second one.

b) There would be an option to "only search photos in XXX resource". As a user, I may be happy having the photos in my local personal contacts, but I do not want to share the photos with google through gmail or my company exchange server. 

I am not sure if they are hard to implement or if the first approach consumes a lot of resources. I think that the real problem is that the same person can be "spread" among different contacts, the same person may have the diffferent email addresses and different people may share the same email address.
Comment 3 Laurent Montel 2013-11-20 07:17:02 UTC
b) I don't want it will add new setup etc. Not good for users.
a) ok I can look at all address and put first contact which has a photo, but if there is 2 different photos ?:)

2) will investigate more.
Comment 4 luisfe 2013-11-22 21:03:42 UTC
Thanks!

I think that in a) taking the first picture found is fair enough.
Comment 5 Laurent Montel 2013-12-10 08:01:46 UTC
Git commit dd24c09c6af98572d733f9e518d89fb3b0501ee6 by Montel Laurent.
Committed on 10/12/2013 at 08:00.
Pushed by mlaurent into branch 'KDE/4.12'.

Fix Bug 327831 - Not all photos from addressbook shows using fancy headers

Now show photo when there is several address item.

M  +11   -1    messageviewer/header/contactdisplaymessagememento.cpp
M  +1    -0    messageviewer/header/contactdisplaymessagememento.h

http://commits.kde.org/kdepim/dd24c09c6af98572d733f9e518d89fb3b0501ee6
Comment 6 Laurent Montel 2013-12-10 08:02:16 UTC
I fixed 'a)'
Comment 7 luisfe 2013-12-12 10:46:21 UTC
I have checked with various configurations and posibilities and photos do appear correctly. In my opinion the bug should be closed as fixed.
Comment 8 Laurent Montel 2013-12-12 11:08:58 UTC
Ok I close it