Bug 327721 - KAboutApplicationDialog: off-by-one error?
Summary: KAboutApplicationDialog: off-by-one error?
Status: RESOLVED WORKSFORME
Alias: None
Product: kdelibs
Classification: Unmaintained
Component: kdeui (show other bugs)
Version: Git
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-17 14:54 UTC by Wolfgang Rohdewald
Modified: 2018-11-12 03:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Rohdewald 2013-11-17 14:54:26 UTC
In kpat(C++) and other apps like kajongg(python),

the license text viewer shows a horizontal scrollbar.

But the source code (master, kaboutapplicationdialog.cpp, line 332)
says:
    // try to set up the dialog such that the full width of the
    // document is visible without horizontal scroll-bars being required

This seems to be an off-by-one error, if the window is broadened
by just one pixel, the scrollbar disappears

I could commit such a fix but I cannot test it because that
would force me to install the whole development thing. I did however
rewrite that part in python, and adding 1 to the calculated idealWidth
indeed fixes this.

Reproducible: Always

Steps to Reproduce:
start kpat, open about dialog, click on license
Actual Results:  
horizontal scroll bar appears

Expected Results:  
should not appear
Comment 1 Andrew Crouthamel 2018-11-11 04:30:14 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 Wolfgang Rohdewald 2018-11-11 13:45:33 UTC
since the Python KDE4 bindings are unmaintained since years, I do not use them anymore. And I do not want to test things with C++. So - no more input from me about this bug.
Comment 3 Andrew Crouthamel 2018-11-12 03:07:20 UTC
Thanks for the update!