Bug 326952 - Crop tool handles on the corners are locked under some circumstances.
Summary: Crop tool handles on the corners are locked under some circumstances.
Alias: None
Product: krita
Classification: Applications
Component: Tools/Transform (show other bugs)
Version: 2.7.4
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
Depends on:
Reported: 2013-10-31 16:04 UTC by Tyson Tan
Modified: 2013-11-15 11:58 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2013-10-31 16:04:30 UTC
Under some circumstances, crop tool handles on the corners are locked. Handles on the side are not affected. Very minor bug with easy workaround. But users may get confused as we often drag handles on the corners first.

Reproducible: Always

Steps to Reproduce:
1.New file (A4@300dpi)
2.Crop tool
3.Drag the handles to include the whole canvas, or with only the UP _OR_ BOTTOM side not touching the canvas edge.
4.Check "%" (keep ratio) box
5.Increase the ratio by clicking on the small arrows beside the number
6.Try drag the handles on the corners, they are all locked.
7.Drag the handles on the sides, they work.
8.Now drag the corner handles again, they work now.
Actual Results:  
Handles lock in their position.

Expected Results:  
Handles can still be dragged around.

Similar operation crashes master builds. Sometimes super weird things happen too, like the image suddenly shrinks-to-nothing.
Comment 1 Tyson Tan 2013-11-01 01:31:56 UTC
It seems this bug affects only portrait images, not landscpae images.
Comment 2 Halla Rempt 2013-11-13 10:02:59 UTC
Git commit a67d11082a3196704b9322df86dbcc62fa0e394d by Boudewijn Rempt.
Committed on 13/11/2013 at 09:59.
Pushed by rempt into branch 'master'.

Various improvements to the crop tool
Related: bug 327319, bug 327318, bug 318885, bug 327536, bug 326933
CCMAIL: wlingflute@gmail.com
Patch by  Michael Martini. Thanks!

In addition a new decoration type has been added called crosshair. In
summary two new checkboxes have been added. One that allows the user to
either limit the crop to the current image size or grow the crop selection
beyond the image boundaries. The second checkbox enables center growing /
symmetric resizing of the crop bounds.

M  +287  -124  krita/plugins/tools/tool_crop/kis_tool_crop.cc
M  +14   -19   krita/plugins/tools/tool_crop/kis_tool_crop.h
M  +46   -3    krita/plugins/tools/tool_crop/kistoolcropconfigwidget.cpp
M  +7    -2    krita/plugins/tools/tool_crop/kistoolcropconfigwidget.h
M  +25   -0    krita/plugins/tools/tool_crop/wdg_tool_crop.ui