Bug 326439 - Multiple steps required (re-work) when entering a dividend payment
Summary: Multiple steps required (re-work) when entering a dividend payment
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.6.4
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 12:55 UTC by Nick Elliott
Modified: 2013-10-23 09:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Elliott 2013-10-22 12:55:45 UTC
Entering dividend transactions has always been confusing in KMyMoney but it's even more so since the upgrade to 4.6.4.

The transaction screens for creating and editing dividends do not behave as expected. Please see 'Steps to Reproduce' for a full explanation.

Reproducible: Always

Steps to Reproduce:
1. In this example I want to enter a dividend of 39.00 (43.33 gross less 4.33 in tax). There are no fees to pay.
2. This is the dividend entry dialogue I see on my system when I enter a new investment transaction: http://i.imgur.com/1osiN9R.png. Note there are no fields to enter the values for 'Fees' or 'Interest', nor is there a 'split transaction' button for 'Interest'.
3. I assume I enter the 4.33 tax deduction against 'Fees' (there is nowhere else to enter it).
4. I choose an expense category for 'Fees' and then KMyMoney adds a field into which I can enter the tax payment of 4.33.
5. I choose an income category for the 'Interest' and, again, KMyMoney opens a field into which I enter 43.33 (the gross amount).
6. At this point the total is correctly displayed as £39.
7. However when I enter the transaction into the ledger the total shows as 43.33 and the value against 'Fees' has disappeared.
8. So I edit the transaction and, as if by magic, a split transaction button has appeared next to the 'Interest' payment, I click this button and add the tax deduction of 4.33.
9. I re-enter the transaction into the ledger now and the total is correctly displayed as 39.00. What's more the tax deduction of 4.33 now shows against the 'Fee' amount.
10. If you then re-edit the transaction it is not possible to make changes to the value of the 'Fee' amount either directly or through the 'Fee' amount 'split transaction' button. You can, however, make changes using the 'Interest' split transaction button by making positive or negative adjustments.
Actual Results:  
When you first enter a new transaction into the ledger it loses the 'Fee' amount.

When you re-edit the transaction a 'split transaction' button appears for the 'Interest' amount and it is only through this method that you can make permanent changes, editing the 'Fee' amount has no effect.

This also means that, unless you only need to enter a net value it is necessary to first create the transaction and then re-edit it in order to successfully record split transactions.

Expected Results:  
The transaction dialogue gives the impression that the 'Fee' value should be used to apply deductions and other charges to the investment transaction. In reality it has no such effect - this is not an intuitive entry screen.

It should be possible to complete the transaction at the time you first created it and not require any re-working on the part of the user.
Comment 1 allan 2013-10-22 15:54:32 UTC
Well, the good news is that the development branch does not show this problem, so , if you are able to build from source, that might be the quickest solution.
That said, the issue with the split button not appearing initially, shows there too.

I'll need to look at 4.6.4.
Comment 2 allan 2013-10-22 20:44:41 UTC
There are two separate problems here.  
The first is where in a dividend transaction, an entered fee does not get saved to the transaction.  This relates to https://bugs.kde.org/show_bug.cgi?id=316111, and the three-line fix was committed as part of Git commit 94935cf78e0135e2bb0cceff3c0dbde8c1c07e6d by Allan Anderson. Committed on 06/03/2013 at 23:41. Pushed by allananderson into branch 'master'.  This was not back-ported to 4.6.4.  I don't yet know if more is needed as there have been quite a few recent changes in this area.
The second is the missing interest category split button on a newly entered dividend transation. This is down to an oversight on my part in -
ID: 6b6aba3f1aaae3c6d7a1466492a8cdb478c10da8
Added by Allan Anderson 20 days ago
BUG:322768 REVIEW:112947 - Interest category and amount disappear
when new fee entered in Dividend.

For ReinvestDividend, BuyShares, SellShares, AddShares, RemoveShares and SplitShares, I hid the interest->splitButton() because where there is no interest-amount there would be no splits.
I didn't hide it for dividend transactions.  However, when a new transaction is opened, it is as a Buy, so the button gets hidden.  When the user edits it to a dividend, I did not un-hide the button again.

So, one fix is needed for HEAD and both for 4.6.4.

The missing split button is pretty straight forward, so I'll fix that first, then think about the other.
Comment 3 allan 2013-10-22 23:51:55 UTC
Git commit b66d9bac8a202176bcfba80917c0860683298123 by Allan Anderson.
Committed on 22/10/2013 at 23:46.
Pushed by allananderson into branch 'master'.

M  +3    -2    kmymoney/dialogs/investtransactioneditor.cpp

http://commits.kde.org/kmymoney/b66d9bac8a202176bcfba80917c0860683298123
Comment 4 allan 2013-10-23 09:39:16 UTC
2013/10/23 Allan <agander93@gmail.com>:
>> Better safe than sorry, what are the steps needed to back-port this to
>> 4.6.4, please.

> There are no steps to do this, 4.6.4 was released and it's the end of
> the 4.6 branch. This fix [for the lost fees issue] will only be available in 4.7.0 whenever it
> will be released.
> Regards,
> Cristian

Otherwise, it's building from source, I'm afraid.