Bug 326421 - Restore chat tabs on session restore
Summary: Restore chat tabs on session restore
Status: REPORTED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui (show other bugs)
Version: 0.6.3
Platform: unspecified Other
: NOR wishlist
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-22 07:13 UTC by Marcus Harrison
Modified: 2014-02-27 17:58 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Harrison 2013-10-22 07:13:04 UTC
Chat windows fail to close properly when I close e.g. a running activity they are on. The contacts window closes fine, as do other applications, but because the chat window is still running I still receive notifications and instant messages from the people involved, even after shutting down the application.

A less serious issue, but the same thing appears to occur on shut-down - the window does not close/the application does not quit when others (KMail, KTP Contacts, Plasma, KWin) do.

Reproducible: Always
Comment 1 Martin Klapetek 2013-10-22 13:51:58 UTC
I believe this is due to the text-ui being started by dbus (which is a special way of starting apps as basically it's not you who is starting it but the system/dbus is).

Not sure how could that be solved though.
Comment 2 David Edmundson 2013-11-04 21:44:36 UTC
"The contacts window closes fine, as do other applications, but because the chat window is still running I still receive notifications and instant messages from the people involved, even after shutting down the application."

That's by design. When you go close the window it doesn't set you as offline. There is a plasmoid you can add to the system tray to show your online status. 

Can you confirm this report is about the chat window staying open, not about remaining online when you close the windows.
Comment 3 Christoph Feck 2013-11-17 13:43:26 UTC
Can someone clarify which information is needed to further investigate this issue?
Comment 4 Martin Klapetek 2013-11-17 13:45:10 UTC
David's last question - "Can you confirm this report is about the chat window staying open, not about remaining online when you close the windows?"
Comment 5 Christoph Feck 2013-11-30 00:40:12 UTC
Marcus, if you can provide the information requested in comment #4, please add it.
Comment 6 Marcus Harrison 2013-12-01 18:57:22 UTC
Sorry. Yes, this bug is specifically about the chat window remaining open. One's status remaining online is a separate issue from my understanding.
Comment 7 Martin Klapetek 2013-12-02 10:40:41 UTC
Ok, thanks. Switching to unconfirmed as I tried to set up activities (I don't use them) to test but I was so confused and had no idea how to actually reproduce.

Can someone using activities please confirm?
Comment 8 Martin Klapetek 2014-02-27 15:05:40 UTC
Getting back to this issue...

Marcus - can you please describe in simple steps on howto reproduce this issue and in the end what happens and then what do you think it should happen instead?

Thanks.
Comment 9 Marcus Harrison 2014-02-27 17:52:15 UTC
The symptom that affects me the most is when logging out/logging back in.

- Go to System Settings->Startup and Shutdown->Session Management and ensure "On Login"->"Restore previous session" is selected

- Open a chat window with someone, or multiple people, using the Telepathy Contacts application

- Log out

- Log back in

What should happen:
The previous chat window/tabs should restore correctly

What actually happens:
The previous chat window/tabs fail to restore correctly

I *believe* this is because the chat window fails to close correctly while other applications do not, but that is pure speculation on my part.
Comment 10 Martin Klapetek 2014-02-27 17:58:00 UTC
Ah! Now I understand.

No, it's a different reason and has to do with Telepathy architecture. Basically each chat tab you open means one new  Telepathy channel is created. When you log out, all channels are cleared, so when you reopen text-ui, no channels exist and therefore no tabs are added back. 

We could possible make it restart the channels on session restore (we do on connection drop out), but no promises :)