Bug 326338 - build of libxslt fails due to incorrect preprocessor instruction
Summary: build of libxslt fails due to incorrect preprocessor instruction
Status: RESOLVED FIXED
Alias: None
Product: kde-windows
Classification: Miscellaneous
Component: buildsystem (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: KDE-Windows
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-20 18:09 UTC by dasaan.san
Modified: 2013-10-31 22:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Patch against: emerge\portage\win32libs\libxslt\libxslt-1.1.26-20101102.diff (1.20 KB, patch)
2013-10-20 18:14 UTC, dasaan.san 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dasaan.san 2013-10-20 18:09:36 UTC 
whilst emerging kdelibs the build of libxslt-1.1.28 fails

Line 1898 of %KDEROOT%\build\win32libs\libxslt-1.1.26-1\work\libxslt-1.1.28\libxslt\xsltutils.c is:
#elif HAVE_GETTIMEOFDAY

which causes a syntax error

changing the line to:
#elif defined(HAVE_GETTIMEOFDAY)

resolved the issue for me.

Reproducible: Always

Steps to Reproduce:
1. emerge kdelibs

Actual Results:  
During the build of libxslt-1.1.28 an error stating that:
#elif with no conditional detected

appears, the build then halts

Expected Results:  
libxslt-1.1.28 should have been built correctly and the emerge process should have continued to the next package
Comment 1 dasaan.san 2013-10-20 18:14:31 UTC 
Created attachment 82976 [details]
Patch against: emerge\portage\win32libs\libxslt\libxslt-1.1.26-20101102.diff

Patch that fixes the malformed pre-processor command
Comment 2 Nico Kruber 2013-10-20 23:15:46 UTC 
thank you for the fix - I'll integrate it next week-end (unless someone has done so by then)

which compiler are you using anyway?
did all my latest changes (updated packages) to the best of my knowledge but only with msvc2010
Comment 3 dasaan.san 2013-10-20 23:40:37 UTC 
I'm building with mingw, I'll make sure to mention it in future reports
Comment 4 dasaan.san 2013-10-31 22:24:54 UTC 
Fixed in commit: a3f18e16cb9fffa406de70c84b855843e10e98a7