Bug 325935 - Start Plugin button does not appear (initially)
Summary: Start Plugin button does not appear (initially)
Status: RESOLVED UNMAINTAINED
Alias: None
Product: konqueror
Classification: Applications
Component: nsplugins (show other bugs)
Version: 4.10.5
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-12 17:42 UTC by Grósz Dániel
Modified: 2024-05-06 21:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Grósz Dániel 2013-10-12 17:42:36 UTC
If loading plugins on demand only is enabled, and a web site containing Flash is loaded, the Start Plugin button does not appear. If I scroll the page a bit or resize the window, the button appears and it works.

This is if I use Webkit. If I use KHTML, the button never appears, though this is probably an unrelated bug since Flash does not work in KHTML even if loading plugins on demand only is disabled.

Reproducible: Always
Comment 1 Grósz Dániel 2013-10-12 19:01:42 UTC
It happens with other types of embedded files (such as text or pdf) too. In that case the behavior is the same with Webkit and KHTML.
Comment 2 Dawit Alemayehu 2014-03-06 13:17:59 UTC
I can confirm this happening sometimes for flash based plugins, but not for other embedded kparts.
Comment 3 avlas 2015-02-24 14:50:16 UTC
I also confirm the bug. I actually wonder why this bug is not receiving attention, as it is very reproducible and quite annoying. Perhaps it is that few developers currently use konqueror (or rekonq) nowadays, or that they load flash content directly (weird) or not at all...
Comment 4 Andrea Iacovitti 2015-02-24 16:22:43 UTC
Could you post an example of page affected by this issue?
Comment 5 avlas 2015-02-24 16:31:16 UTC
This is just an example I can recall now:

http://www.ara.cat/arabassas/LEditorial-Antoni-Bassas-Vuit-dramatiques_3_1309699022.html

I will try to find others...

Thanks
Comment 6 avlas 2015-02-24 16:53:07 UTC
I think I can refine where the actual problem is.

The issue is not there anymore when a web page tries to directly load a flash video (this has been properly fixed, as far as I can see), but persists if the flash video needs to be manually activated with a play button (such as in the example above).

In that case, clicking in the play button creates a black video frame and the start plugin is missing, which is confusing for the final user. Only if one reshapes the window, the start plugin button appears.

I would propose two ways of solving this issue, although I don't know which one is easier to implement:

- for the cases that a play button exist, there is actually no need for the start plugin, so it could be disabled for those cases.

- if previous point is difficult to implement, could it be easier to trigger the start plugin button right after manually clicking the play button?
Comment 7 Grósz Dániel 2015-02-24 18:16:09 UTC
(In reply to Andrea Iacovitti from comment #4)
> Could you post an example of page affected by this issue?

Any page with flash for me.

(In reply to avlas from comment #6)
> - if previous point is difficult to implement, could it be easier to trigger
> the start plugin button right after manually clicking the play button?

I'm pretty sure that's the intended behavior; that it doesn't happen is a bug that should be fixed.
Comment 8 Andrea Iacovitti 2015-02-26 14:50:13 UTC
Git commit abdf2417cfefc360c78696485842a131a1cff048 by Andrea Iacovitti.
Committed on 26/02/2015 at 14:44.
Pushed by aiacovitti into branch 'Applications/14.12'.

Use default color palette for "Start Plugin" button to ensure its visibility.

M  +4    -3    nsplugins/nspluginloader.cpp

http://commits.kde.org/kde-baseapps/abdf2417cfefc360c78696485842a131a1cff048
Comment 9 avlas 2015-02-26 14:58:20 UTC
Is this a problem of visibility only? If that would be the case clicking on the invisible button (at the center of the video fram) should work but that doesn't seem to be the case...

But perhaps I'm missing something
Comment 10 Andrea Iacovitti 2015-02-26 15:30:21 UTC
(In reply to avlas from comment #9)
> 
> Is this a problem of visibility only?
As i understand it, this is the problem this bug report was opened for.

The other issue you mentioned in previous comment has nothing to do with this ticked and probably is already tracked by bug 246736 (haven't go in deep to tell for sure).
Comment 11 avlas 2015-02-26 15:39:56 UTC
If you read the comments, in particular the first one, it points to something that is not about the color in which the button Start Plugin appears, but to the fact that the button does not appear (exist) until you resize the window. So I would say you fixed a bug that is not what the intention of this bug was about (although the title may be confusing and the bug may certainly be a duplicate of the bug you mentioned).

Am I wrong?
Comment 12 Grósz Dániel 2015-02-26 15:56:29 UTC
It doesn't work for me either if I click where the button is supposed to be when it's not visible.

For whatever reason, now the bug doesn't manifest for me with youtube, whether on the site or embedded. (A few days ago it still happened. Maybe an update?) But the bug still happens on other sites with flash.
Comment 13 Andrea Iacovitti 2015-02-26 17:19:29 UTC
(In reply to avlas from comment #11)
> 
> If you read the comments, in particular the first one, it points to
> something that is not about the color in which the button Start Plugin
> appears, but to the fact that the button does not appear (exist) until you
> resize the window. So I would say you fixed a bug that is not what the
> intention of this bug was about (although the title may be confusing and the
> bug may certainly be a duplicate of the bug you mentioned).
> 
> Am I wrong?

Second line of comment 0 "If I use KHTML, the button never appears ...".
The fix address nspluginviewer that is only used by KHTML and not Webkit rendering engine and, at least for me,
it makes the "Start Plugin" button clearly visible for youtube flash content (previously was rendered with transparent color, thus invisible).


(In reply to Grósz Dániel from comment #12)
> It doesn't work for me either if I click where the button is supposed to be
> when it's not visible.
> 
> For whatever reason, now the bug doesn't manifest for me with youtube,
> whether on the site or embedded. (A few days ago it still happened. Maybe an
> update?) But the bug still happens on other sites with flash.

Could you please clarify which "other sites with flash" are you referring to by posting url and/or a screenshot?
Thank you.
Comment 14 avlas 2015-02-26 17:27:29 UTC
Oh, I see. You fixed the part of the bug report specifically related to the invisibility under KHTML rendering... (I didn't realize of this, as I use Webkit)
Comment 15 Grósz Dániel 2015-02-26 17:44:55 UTC
> Could you please clarify which "other sites with flash" are you referring to
> by posting url and/or a screenshot?
> Thank you.

Youtube and dailymotion are fine.
Examples I found with the bug:
http://index.hu/video/2015/02/24/budacash/
http://www.timesofisrael.com/false-israel-drowns-gaza-claims-sweep-internet/ (This one should load after clicking on it, but the index.hu one should load immediately.)
Comment 16 Christoph Cullmann 2024-05-06 21:07:10 UTC
Dear user,

KHTML (and KJS and all related Java/plugin infrastructure) was a long time more or less unmaintained and got removed in KF6.

Please migrate to use a QWebEngine based HTML component.

We will do no further fixes or improvements to the KF5 branches of these components beside important security fixes.

For security issues, please see:

https://kde.org/info/security/

Sorry that we did not fix this issue during the life-time of KHTML.

Greetings
Christoph Cullmann