Bug 325062 - Can not undo winning move
Summary: Can not undo winning move
Status: RESOLVED INTENTIONAL
Alias: None
Product: kpat
Classification: Applications
Component: general (show other bugs)
Version: 3.6
Platform: Debian stable Linux
: NOR wishlist
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-18 14:45 UTC by BryanFRitt
Modified: 2023-02-28 23:18 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BryanFRitt 2013-09-18 14:45:27 UTC
Finish a game, or deal (, or what ever it's called) with a winning move, and the last move, etc... won't be undo-able.
The last move should be undo-able. Undoing the last move should also revert the winning statistics to what it was before the move, and count as a win after a redo, or somehow getting the game back to a winning state. 
Undo list should be reset when a new game is started instead of when a game ends. (although there could be something like an undo-to-previous-game method/button/menu item that reverts back to the previous games winning state)

Having the undo feature available after a win can help review what the last move, etc... were; Like when an 'Autodrop' occurs and you didn't catch what the move(s) was(were), or just want to review the game.


Reproducible: Always

Steps to Reproduce:
1. Finish a game with a winning move
2. Try to undo the last move

Actual Results:  
The last move can't be undone

Expected Results:  
The last move can be undone
Comment 1 Stephan Kulow 2023-02-28 16:46:16 UTC
That would make many things way more difficult to track - I don't think it's feasible.
Comment 2 BryanFRitt 2023-02-28 23:18:24 UTC
(In reply to Stephan Kulow from comment #1)
> That would make many things way more difficult to track - I don't think it's
> feasible.

Instead of "Undoing the last move should also revert the winning statistics to what it was before the move, and count as a win after a redo, or somehow getting the game back to a winning state." For simplicity, just add it to the winning statistics when 1st win, and after that don't update any statistics for this deal, even if re-won or quit.

The last move should be able to be undone(, or even, if possible, continued from?). Although I suppose there could be an issue in doing so with the winning animations. Reverse them?

p.s.

Wish there was a "RESOLVED" "DON'T FEEL LIKE CHANGING IT" or something like that. Which I'm guessing would probably make more since in this case at least. I doubt having this request somehow being done and bug free would be a bad thing that someone would prefer it not to have had been done, like the current status of "RESOLVED" "INTENTIONAL" implies. 

Even if you for some reason disagree with me on it being done as a good thing in this case, there still should be a "RESOLVED" "DON'T FEEL LIKE CHANGING IT"(, or something like that, ) option available for this, and for other issues.