Bug 325052 - JJ: Isolate layer mode
Summary: JJ: Isolate layer mode
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: git master (please specify the git hash!)
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-09-18 11:34 UTC by Bollebib
Modified: 2016-07-22 09:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Proposed fix (39.71 KB, patch)
2015-04-26 22:41 UTC, kde
Details
Option 2 (12.97 KB, patch)
2015-05-03 03:43 UTC, kde
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2013-09-18 11:34:24 UTC
Currently isolate layer works till you select a different layer 

that is great for some workflows.

It would be a good addition to have an extra function where you can enter isolate layer mode,and it only leaves isolation layer mode if you press the keyboard shortcut linked to it. Another way would be to rightclick layerstack layer and deselect the isolate layer mode.

The reason for a specific mode is when you are working with many (similar,but also different) layers and you need to constantly invoke isolate layer. A mode would make it so you only need to invoke it once,and then only leave when you choose. 

This is also great if you want to compare 2 layers by toggling between them in isolate layer mode
It would make it easier to spot differences and mistakes between them,or which one is prefered.


Isolate layer and isolate layer mode can be seperate functions for different needs.


I don't think this should have a default shortcut,that should be up to those who want/need it.
Comment 1 Dmitry Kazakov 2014-09-02 06:54:33 UTC
Fixed in master some time ago. Now you can Alt-click on a layer to make it isolated
Comment 2 Bollebib 2014-10-12 10:47:28 UTC
Alt-click is great but is not the answer to the issue.

Alt+click only works when layer ,and while much quicker,it still results in pointless clicking and scrolling.

I would like a solution that only needs shortcuts.

this is the usecase: 
1)press shortcut to initiate DEDICATED isolate layer mode
2)use keyboardshorcuts like PG UP and PG DOWN to move through all the different layers.
->isolate layer mode stays active
3)press shortcut to leave DEDICATED isolate layer mode




This can be done in a few ways:

1) create a seperate functions (isolate layer and isolate layer MODE) with it's own shortcuts and naming (isolate mode / isolate layer) 

=>easier to understand, seperated functions ,no current workflow is lost


2) have an option to toggle between automatic and manual mode of isolate layer
=>benefit: only 1 shortcut and name ,but maybe more obscure to know what the difference is.



11:17:16 - Bollebib: dmitryK dmitryK_ ping
11:18:13 - dmitryK: Bollebib: pong
11:19:16 - Bollebib: dmitryK: I don't remember since our last conversation if you still had any remarks or questions about the isolate layer mode (there were a lot of conversations at the same time)
11:19:30 - Bollebib: do you want me to add the info to the bug and reopen it?
11:20:12 - dmitryK: Bollebib: yes, sure. Reopen it and add the info
11:20:58 - dmitryK: Bollebib: Otherwise, I'm afraid I will have to search for xchat logs when facing this bug again
11:21:01 - Bollebib: similarly this all could be solved if you could set isolate layer to manual mode instead of automatic,maybe that is an easier solution?
11:21:35 - Bollebib: I don't know what would be preferable to you
11:23:33 - Bollebib: dmitryK: so the options are
11:23:33 - Bollebib: 1) create a seperate function with it's own shortcuts and naming (isolate mode / isolate layer)
11:23:33 - Bollebib: 2) have an option to toggle between automatic and manual mode of isolate layer (n only 1 shortcut and naming scheme)
11:23:48 - Bollebib: the second might be easier?
11:23:56 - Bollebib: and less UI hassle
11:24:55 - Bollebib: then you would need to define what manual and what automatic is (automatic is the current way)
11:25:03 - dmitryK: Bollebib: better explain the usecase and provide both options, and we will try to evaluate both options later. Speaking truly, I cannot tell which way is easier/user-friendly "_
Comment 3 kde 2015-04-26 22:41:03 UTC
Created attachment 92239 [details]
Proposed fix

Turns mode on for current active layer after stopping mode for previous active layer.

I'm new to open source so any feedback is much appreciated. :-)
Comment 4 kde 2015-04-26 22:50:52 UTC
Oops. I assumed attachments would automatically detect and show just the diff. I only changed slotTryFinishIsolatedMode().
Comment 5 kde 2015-04-27 07:33:58 UTC
Ignore my fix. Now realizing what's meant by automatic and manual.
Comment 6 Halla Rempt 2015-04-27 07:43:39 UTC
Hi Tiffany!

Thanks for looking into the bug in any case! If you want to go on, the best way to submit a fix is by typing "git diff > bug324042.patch" (or any other relevant name), and then add that file as an attachment. That makes it possible for us to immediately see what you changed.b
Comment 7 kde 2015-05-03 03:43:52 UTC
Created attachment 92382 [details]
Option 2

Giving this another go. Since this details for this bug are still up for discussion, I put together a mock-up for the 2nd option: "have an option to toggle between automatic and manual mode of isolate layer"

I wasn't sure where the option to switch between automatic and manual should go so I put it under "Settings > Configure Krita... > Display," thus it's saved in config. To isolate layer, use existing single shortcut as usual.
Comment 8 Bollebib 2015-05-03 21:30:44 UTC
I'll try and test this asap,but I'll need to ask on IRC how to patch krita .

At first glance I would think automatic vs manual should be able to be done more on the fly,but then again,I'm not sure where else to put it...

but that's effectively why I said it might need to be 2 seperate functions...


I'm torn  =D

I'll need to test first and see if it's a big hindrance and / or if it does what I describe.

In any case,thank you for trying to solve this bug.
Comment 9 kde 2015-05-06 07:07:28 UTC
Ah, I didn't intend that to solve it. Just throwing a model/variation out there. :)

A whole bunch of UI possibilities went through my head, for option 1 and/or 2, going through the bug:

1. Add a small switch icon (say, next to or below the "Minimal/Detailed/Thumbnail View" icon) in the layer dock to quickly toggle it between automatic and manual.
2. Add a "Isolate Layer Mode" below "Isolate Layer" in the layer dock's right-click menu. But then 2 caveats: (a) the menu becomes too cluttered, or (b) it'd be difficult distinguishing the difference, and what both options should look like (e.g. disabled, checked, etc) while in one mode or the other, or no in mode at all.
3. Just one "Isolate Layer" in the menu. Click on it to open up a side menu ("Isolate Layer >") or a tiny dialog ("Isolate Layer...") to choose. Then again, that's more UI.
4. Don't add it anywhere at all. You set them in "Configure shortcuts..." and remember the two shortcuts from then on -- well, maybe that's too extreme.
Among other erratic ones.

I think we'd first have to consider how often most people _would_ switch between automatic and manual, to see if it's worth taking up that extra dock space or taking up a 2nd shortcut?

Most definitely torn!
Comment 10 Halla Rempt 2016-01-24 14:30:36 UTC
WISHGROUP: Larger Usability Fixes

This really needs to be discussed with Dmitry again because we cannot figure out the actual use-case.
Comment 11 Bollebib 2016-01-30 14:47:04 UTC
(In reply to Boudewijn Rempt from comment #10)
> WISHGROUP: Larger Usability Fixes
> 
> This really needs to be discussed with Dmitry again because we cannot figure
> out the actual use-case.

talk to me on IRC if you like

I did explain the usecase  in this comment thread

It's to have a permanent isolate layer going,so you can jump through your layers while searching for something.

Another usecase is if you have an animation on different layers,you can go up and down the stack to check if the flow is correct. This is something I have needed when I worked on skullgirls. They want their animations in a PSD ,so the only way to do this was put the layers in sequence . 

But to still be able to work on them even after you put them in layerstack ,isolatat layer mode would be useful. Regardles if krita has animation,this is an actual usecase I have had to use for several months.

Besides that it's just easier to flip through layers and compare without needing to input shortcuts all the time. 
I'm a heavy isolate layer user,but it's easier to just activate it and flip through layers ,then deactivate. Then to press the shortcut,siwtch layer,press shortcut again,switch layer,etc X20

expecially for MANY layers this becomes a huge issue.
Comment 12 Bollebib 2016-05-14 17:04:52 UTC
https://www.youtube.com/watch?v=KbCcjjPcUAw&feature=youtu.be


I made a video to illustrate my issue.


The main thing this would solve is speed an ease of use for constant layer-switching which I need to do a lot,depending on the project at hand.

You clearly see that comparing and browsing layers is much faster this way. And yes it is only possible with isolate layer. Hiding ,unhiding layers will never be as fast as this. You can compare and browse quickly,disable layer only and continue working.
Comment 13 Halla Rempt 2016-06-16 09:07:40 UTC
Bugzilla wants a comment.
Comment 14 Bollebib 2016-06-16 11:50:11 UTC
(In reply to Boudewijn Rempt from comment #13)
> Bugzilla wants a comment.

Is that directed at me? I'm sorry I don't understand.
Comment 15 Halla Rempt 2016-06-16 12:16:34 UTC
No, but I cannot change the status without adding a bit of text.
Comment 16 Bollebib 2016-06-16 12:38:23 UTC
Oooh,okay. I didn't realize that. Thanks for confirming =)
Comment 17 Dmitry Kazakov 2016-07-22 09:45:29 UTC
Git commit f6b1c94cca22f854982afcb9031ac6580c463054 by Dmitry Kazakov, on behalf of Alexey Kapustin.
Committed on 22/07/2016 at 09:45.
Pushed by dkazakov into branch 'master'.

Isolation mode is now saved when you move between layers.
When moving to a higher layer level , all the sub-layers are visible.

Now to exit Isolate Layer you can either toggle the checkbox in
a context menu or just Alt+click on the currently selected layer.

Reviewers: #krita, dkazakov
Subscribers: dkazakov, woltherav
Tags: #krita
Differential Revision: https://phabricator.kde.org/D2213
CC:kimageshop@kde.org

M  +1    -14   libs/ui/kis_node_manager.cpp

http://commits.kde.org/krita/f6b1c94cca22f854982afcb9031ac6580c463054