Bug 323945 - APG runs only when "Playlist duration" constraint is specified
Summary: APG runs only when "Playlist duration" constraint is specified
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlists/Automated Playlist Generator (show other bugs)
Version: 2.8-git
Platform: Kubuntu Linux
: NOR normal
Target Milestone: 2.9
Assignee: Amarok Developers
URL:
Keywords: regression
: 352939 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-23 21:26 UTC by vedant agarwala
Modified: 2015-09-20 11:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.9


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vedant agarwala 2013-08-23 21:26:34 UTC
If an APG does not contain the "Playlist duration" constraint, nothing happens when the run APG button (blue right arrow) is clicked. Also, if I try to a "Playlist duration" constraint like "longer than" 2 minutes (so that this is a redundant constraint), nothing happens.
By nothing happens I mean a statusbar is shown (probably the "generating playlist" statusbar) for a split second and no change is made to the playlist.

Reproducible: Always
Comment 1 Myriam Schweingruber 2015-03-01 15:01:29 UTC
Easy workaround: select a long duration and select the option "longer than".

But, comfirmed on current git, v2.8.0-458-g53f0980, and this is a regression as it used to work before.
Comment 2 Soren Harward 2015-06-01 02:57:26 UTC
Git commit 0b7492e709d9c8c37e8d9e74f549d0073b775b19 by Soren Harward.
Committed on 01/06/2015 at 02:53.
Pushed by stharward into branch 'master'.

Fix long-standing bug: APG returns empty playlist

Well, that was dumb.  Added a sanity check where if the suggested
playlist size is 0 (which means "I don't really care what the playlist
size is"), then just go with whatever the non-zero size from the
previous iteration was.
Related: bug 313762, bug 315206

FIXED-IN: 2.9

M  +2    -0    ChangeLog
M  +2    -1    src/playlistgenerator/ConstraintSolver.cpp

http://commits.kde.org/amarok/0b7492e709d9c8c37e8d9e74f549d0073b775b19
Comment 3 Soren Harward 2015-09-20 11:29:56 UTC
*** Bug 352939 has been marked as a duplicate of this bug. ***