Bug 323512 - Rating filter in Files does nothing
Summary: Rating filter in Files does nothing
Status: RESOLVED FIXED
Alias: None
Product: Active
Classification: Plasma
Component: Applications (show other bugs)
Version: PA 4
Platform: unspecified Linux
: NOR major
Target Milestone: unscheduled
Assignee: active
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-14 20:33 UTC by Thomas Pfeiffer
Modified: 2013-08-16 17:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Pfeiffer 2013-08-14 20:33:56 UTC
When tapping any of the stars in "Rating" in Files, nothing happens, all files are still shown

Reproducible: Always

Steps to Reproduce:
1. Open Files
2. Tap a star below "Rating"

Actual Results:  
All files are shown

Expected Results:  
Only files with the selected rating are shown
Comment 1 Marco Martin 2013-08-15 12:08:32 UTC
Git commit a0507ec2a0d6082ccc8ebdbd8d89258410ec7d27 by Marco Martin.
Committed on 15/08/2013 at 12:07.
Pushed by mart into branch 'Active/4'.

minimumRating is now a property of queryProvider

M  +1    -1    applications/filebrowser/package/contents/ui/CategorySidebar.qml

http://commits.kde.org/plasma-mobile/a0507ec2a0d6082ccc8ebdbd8d89258410ec7d27
Comment 2 Thomas Pfeiffer 2013-08-15 18:06:33 UTC
Um sorry, that didn't really work :(
When I tap a star, it automatically switches to "Current Activity". If I have a file in the current Activity it is shown, but regardless of its rating. So it does not filter for rating but for "Current Activity" instead
Comment 3 Thomas Pfeiffer 2013-08-16 10:06:54 UTC
Almost there ;)
It works now basically (even without any file type or Current Activity selected, which is pretty awesome).
The only problem left is that when I select one star, I only get files with at least 2 stars, if I click 2 stars, I only get files with 3 stars and so on).
If that is corrected, everything is fine on this front!
Comment 4 Thomas Pfeiffer 2013-08-16 17:27:24 UTC
Now it works!