Bug 323238 - [tabbed mdi issues] Shortcut settings being lost on every file tab switch
Summary: [tabbed mdi issues] Shortcut settings being lost on every file tab switch
Status: RESOLVED FIXED
Alias: None
Product: lokalize
Classification: Applications
Component: editor (show other bugs)
Version: 1.5
Platform: Kubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Simon Depiets
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-06 17:21 UTC by Serhiy Zahoriya
Modified: 2018-09-10 10:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Serhiy Zahoriya 2013-08-06 17:21:09 UTC
Steps to reproduce:
1. Open two .po files.
2. Change any shortcut settings.
3. Switch to another file tab.
4. Check the shortcut settings again.

Version: 4:4.10.5-0ubuntu0.1~ubuntu12.04~ppa1
Comment 1 Serhiy Zahoriya 2013-08-06 17:25:26 UTC
A workaround is to open two windows.
Comment 2 Simon Depiets 2018-09-10 10:11:14 UTC
Git commit ba259bf56a28706482d0f058a26e1e3f23fc0d22 by Simon Depiets.
Committed on 10/09/2018 at 10:10.
Pushed by sdepiets into branch 'master'.

Reload UI XML files on tab change for shortcut updates

Summary:
This patch will reload the .ui files of the tabs (editor tab/tm/project) if a newer version exists.
This will allow propagation of the shortcut updates to the KActionCollections and new shortcuts won't be lost anymore on tab change.

https://bugs.kde.org/show_bug.cgi?id=323238
Shortcut settings being lost on every file tab switch
Steps to reproduce:
1. Open two .po files.
2. Change any shortcut settings.
3. Switch to another file tab.
4. Check the shortcut settings again.

https://bugs.kde.org/show_bug.cgi?id=302853
Customized shortcut resetting when switching to TM tab
Related: bug 302853

Test Plan:
1. Open two .po files.
2. Change any shortcut settings.
3. Switch to another file tab.
4. Check the shortcut settings again.

Reviewers: #localization, aacid, ltoscano

Subscribers: dfaure

Tags: #localization

Differential Revision: https://phabricator.kde.org/D14936

M  +8    -8    src/editortab.cpp
M  +6    -3    src/lokalizemainwindow.cpp
M  +27   -0    src/lokalizesubwindowbase.h
M  +1    -0    src/project/projecttab.cpp
M  +1    -0    src/tm/tmtab.cpp

https://commits.kde.org/lokalize/ba259bf56a28706482d0f058a26e1e3f23fc0d22