Bug 322899 - Legend for some map themes doesn't look as intended
Summary: Legend for some map themes doesn't look as intended
Status: RESOLVED WORKSFORME
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.6 (KDE 4.11)
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-27 22:32 UTC by Lasse Liehu
Modified: 2018-11-11 03:03 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of the legend for Moon (598.98 KB, image/png)
2013-07-27 22:32 UTC, Lasse Liehu
Details
Patch that makes the legend for Moon look fine (605 bytes, patch)
2013-07-27 22:33 UTC, Lasse Liehu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lasse Liehu 2013-07-27 22:32:44 UTC
Created attachment 81395 [details]
Screenshot of the legend for Moon

Steps to reproduce:
1. Switch the current map theme to the built-in Moon one.
2. Look at the legend.

Actual results:
The legend looks to use some default serif font and has almost the same appearance as the legend for the Atlas and OpenStreetMap map themes, but not quite. See the attached screenshot.

Legend looks the same also for the the following map themes (installed using File | Download Maps...): Saturn - Dione and Saturn - Titan.

Expected results:
The legend uses the same style as it does for the built-in Atlas and OpenStreetMap map themes or at least doesn't use half the same style, looking like it's missing some CSS.

Browsing the code it seems the Moon map theme's legend.html is missing include for Bootstrap. Attached is a patch that makes the legend look fine and the same as legends for Atlas and OpenStreetMap.

The reason I didn't just make a review request with that patch was because the problem probably exists for many map themes not shipped with Marble, i.e. their legend will look worse with Marble 4.11.
Comment 1 Lasse Liehu 2013-07-27 22:33:37 UTC
Created attachment 81396 [details]
Patch that makes the legend for Moon look fine
Comment 2 Andrew Crouthamel 2018-11-10 03:17:32 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Lasse Liehu 2018-11-10 10:12:33 UTC
The legend for Moon seems to be fixed.
Comment 4 Andrew Crouthamel 2018-11-11 03:03:31 UTC
Thanks for the update!