Bug 322765 - font height change breaks rendering, clips bottoms of text, underscores missing
Summary: font height change breaks rendering, clips bottoms of text, underscores missing
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: part (show other bugs)
Version: Git
Platform: Other Linux
: NOR grave
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-24 12:41 UTC by edA-qa mort-ora-y
Modified: 2013-07-25 07:49 UTC (History)
0 users

See Also:
Latest Commit: http://commits.kde.org/kate/9526d0d9670f51fbe3932da2231dedb586eb1bc7
Version Fixed In:

Attachments
screenshot: working prior to this revision (6.10 KB, image/png)
2013-07-24 12:42 UTC, edA-qa mort-ora-y 		Details
screenshot: showing missing underscores (7.61 KB, image/png)
2013-07-24 12:43 UTC, edA-qa mort-ora-y 		Details
screenshot: showing pronounced height problem (8.06 KB, image/png)
2013-07-24 12:43 UTC, edA-qa mort-ora-y 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description edA-qa mort-ora-y 2013-07-24 12:41:31 UTC 
The below commit breaks the rendering of fonts. In particular it no longer seems to calculate the height correctly. With my font settings I no longer see the underscores of the font. I've attached a screenshot showing the same font without this change, and the result just after moving to this revision.  The effect varies depending on the font, some work, some don't. I've also attached one other screenshot showing a more pronounced clipping effect, done by alternating between fonts in the config window.

commit 617971f6192ef609acc7775881497e1b5626bfbf (HEAD, refs/heads/master)
Author: Christoph Cullmann <cullmann@kde.org>
Date:   Wed Jul 17 10:18:21 2013 +0200
    try to initialize the font size always right


Reproducible: Always
Comment 1 edA-qa mort-ora-y 2013-07-24 12:42:27 UTC 
Created attachment 81315 [details]
screenshot: working prior to this revision
Comment 2 edA-qa mort-ora-y 2013-07-24 12:43:01 UTC 
Created attachment 81316 [details]
screenshot: showing missing underscores
Comment 3 edA-qa mort-ora-y 2013-07-24 12:43:26 UTC 
Created attachment 81317 [details]
screenshot: showing pronounced height problem
Comment 4 edA-qa mort-ora-y 2013-07-24 12:44:35 UTC 
The font I normally use is "DejaVu Sans", Book, 11
Running on Kubuntu 12.04 (up-to-date)
Comment 5 Dominik Haumann 2013-07-24 13:30:30 UTC 
The screenshot shows that the font is not just off by 1 pixel. Instead, it is shifted down quite a lot. To me this looks like a broken font installation for whatever reason. Or to phrase it differently: No idea what we can do about it in Kate...
Comment 6 edA-qa mort-ora-y 2013-07-24 16:15:25 UTC 
Broken font installation? The error is introduced by a specific revision in the git tree. It affects numerous fonts, not just one, and there are no other font problems on my system.
Comment 7 Dominik Haumann 2013-07-24 16:43:11 UTC 
Ah, now I see. Do you run Kate from git? If so, what parts of the commit need to be reverted in order to fix the issue again?
Comment 8 edA-qa mort-ora-y 2013-07-24 16:52:46 UTC 
The commit is actually quite small, all dealing with the font bits. It'd probably be safer to revert the entire commit as an interim solution -- and then later find the correct way to fix what the revision intended to do.
Comment 9 Christoph Cullmann 2013-07-25 07:49:57 UTC 
Git commit 9526d0d9670f51fbe3932da2231dedb586eb1bc7 by Christoph Cullmann.
Committed on 25/07/2013 at 07:49.
Pushed by cullmann into branch 'master'.

try to use old method of font height computation

M  +3    -3    part/render/katerenderer.cpp

http://commits.kde.org/kate/9526d0d9670f51fbe3932da2231dedb586eb1bc7