Bug 322488 - Use a single timer to monitor directory changes
Summary: Use a single timer to monitor directory changes
Status: CONFIRMED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-17 14:13 UTC by Christoph Feck
Modified: 2018-03-24 18:52 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2013-07-17 14:13:42 UTC 
Konsole currently uses a QTimer for each tab to monitor directory changes. It could use a single QTimer for all open tabs to reduce wake-ups.

To reproduce:
- open root Konsole
- run powertop for this single tab for a while
- open 10 additional tabs
- watch powertop on first tab for a while

Actual results:
- for a single tab, Konsole wakes up 0.5 times per second
- for 11 tabs, Konsole wakes up 5.5 times per second

Expected results:
- for 11 tabs, Konsole wakes up 0.5 times per second
Comment 1 Kurt Hindenburg 2013-08-03 21:46:33 UTC 
Yes, the SessionController::snapshot is called every .5 seconds per tab
Comment 2 Ahmad Samir 2018-03-20 14:51:22 UTC 
Is this still valid? (if so how to detect the wakes-up per second? :)).
Comment 3 Christoph Feck 2018-03-21 00:22:45 UTC 
Comment #0 says I used "powertop" to measure wakeups.
Comment 4 Ahmad Samir 2018-03-24 18:52:12 UTC 
I tested and I don't see a difference; I think it's probably due to the fact that I am using a PC, I don't have access to a laptop. Sorry for the noise.