Bug 322221 - Spelling error. "allows to" -> "allows one to"
Summary: Spelling error. "allows to" -> "allows one to"
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: accounts-kcm (show other bugs)
Version: 0.6.2
Platform: Debian unstable Linux
: NOR wishlist
Target Milestone: Future
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-11 02:10 UTC by Diane Trout
Modified: 2013-07-13 10:28 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diane Trout 2013-07-11 02:10:16 UTC
There's two strings using the phrase "This button allows to change the". It should be "This button allows one to change the" or "This button allows changing". 

Reproducible: Always

Steps to Reproduce:
grep -r "allows to" ktp-accounts-kcm
Actual Results:  
grep -r "allows one to" 


Possible patch

--- a/src/accounts-list-delegate.cpp
+++ b/src/accounts-list-delegate.cpp
@@ -68,7 +68,7 @@
     ChangeIconButton *changeIconButton = new ChangeIconButton();
     changeIconButton->setFlat(true);
     changeIconButton->setToolTip(i18n("Change account icon"));
-    changeIconButton->setWhatsThis(i18n("This button allows to change the icon for your account.<br />"
+    changeIconButton->setWhatsThis(i18n("This button allows one to change the icon for your account.<br />"
                                   "This icon is just used locally on your computer, your contacts will not be able to see it."));
 
     QLabel *statusTextLabel = new QLabel();
@@ -77,7 +77,7 @@
     EditDisplayNameButton *displayNameButton = new EditDisplayNameButton();
     displayNameButton->setFlat(true);
     displayNameButton->setToolTip(i18n("Change account display name"));
-    displayNameButton->setWhatsThis(i18n("This button allows to change the display name for your account.<br />"
+    displayNameButton->setWhatsThis(i18n("This button allows one to change the display name for your account.<br />"
                                          "The display name is an alias for your account and is just used locally "
                                          "on your computer, your contacts will not be able to see it."));
Comment 1 Martin Klapetek 2013-07-12 11:06:06 UTC
Git commit 32b49c8ae5dbc68dee4902d66a2ee87b422e91ab by Martin Klapetek, on behalf of Diane Trout.
Committed on 12/07/2013 at 11:05.
Pushed by mklapetek into branch 'master'.

Spelling in "what's this" tooltip fix

M  +2    -2    src/accounts-list-delegate.cpp

http://commits.kde.org/telepathy-accounts-kcm/32b49c8ae5dbc68dee4902d66a2ee87b422e91ab
Comment 2 Martin Klapetek 2013-07-12 11:07:11 UTC
Thanks for the report and especially the patch, Diane! Nice work :)
Comment 3 Pino Toscano 2013-07-13 10:28:19 UTC
Git commit fa9bc0c78c57d8f3bfd18d3e32d7963a3acffcf6 by Pino Toscano.
Committed on 13/07/2013 at 10:27.
Pushed by pino into branch 'master'.

i18n: fix logic

M  +2    -2    src/accounts-list-delegate.cpp

http://commits.kde.org/telepathy-accounts-kcm/fa9bc0c78c57d8f3bfd18d3e32d7963a3acffcf6