Bug 321992 - Feature request: Can the highlighter automatically fill the attached pop-up note with highlighted text.
Summary: Feature request: Can the highlighter automatically fill the attached pop-up n...
Status: CONFIRMED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 0.16.4
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-05 13:10 UTC by klooter123
Modified: 2016-10-07 13:50 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Okular, Docear, & UberStudent - implementation conversation (452.79 KB, application/pdf)
2013-07-16 18:38 UTC, Stephen Ewen
Details
attachment-6547-0.html (1.59 KB, text/html)
2015-03-27 21:25 UTC, John SQ Liu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description klooter123 2013-07-05 13:10:36 UTC
When highlighting or underlining text in pdfs the attached pop-up notes used to edit the annotations are initially empty. Would it be possible to include an option for the pop-up notes to initially contain the highlighted or underlined text. This would help with sharing annotations with other software (such as docear).

Thanks!

Reproducible: Always
Comment 1 Stephen Ewen 2013-07-16 18:38:44 UTC
Created attachment 81145 [details]
Okular, Docear, & UberStudent - implementation conversation

Yes, this feature request is very important!

Please see the attached conversation between myself and the Docear lead developer about it. 

Coding this fix myself is beyond my own ability or I'd do it myself.
Comment 2 Kirill I. Krasnoschekov 2014-03-27 10:10:02 UTC
I use Okular with Docear too and approve that this feature will be very helpful for good integration with Docear.
Comment 3 scubbx 2015-02-10 17:24:23 UTC
This feature is somewhat necessary for a productive use of Okular together with Docear. I very much whish for this feature !
Comment 4 John SQ Liu 2015-03-27 02:37:55 UTC
Hello I'm an Okular and Docear user.  I modified a few lines in ui/pageviewannotator.cpp's TextSelectorEngine to implement the requested feature.  Would you be interested in including it as default behavior or potentially as a menu option?
Comment 5 Kirill I. Krasnoschekov 2015-03-27 15:56:23 UTC
I would prefer to make it the default behaviour as I can't imagine the situation where this pasted text can harm someone. (But developers may have different opinions.)
Comment 6 Albert Astals Cid 2015-03-27 16:44:07 UTC
On the other hand i can't imagine a situation in which i would want that, this just looks like you're trying to fix a limitation in docear making okular do something weird.

I mean i am highlighting the text, as a user why would i want the note of that highlighted text be the test himself?
Comment 7 Kirill I. Krasnoschekov 2015-03-27 17:37:02 UTC
This sounds reasonable. But at least having this behaviour as an option wouldn't go amiss.

(Maybe it's too complicated to fetch the text which was highlighted from Docear or any other external applicaion, I don't know.)
Comment 8 John SQ Liu 2015-03-27 21:25:56 UTC
Created attachment 91786 [details]
attachment-6547-0.html

If you need to export annotations, this would give access to highlight text
in the XML output.

On Sat, Mar 28, 2015 at 12:44 AM, Albert Astals Cid <aacid@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=321992
>
> Albert Astals Cid <aacid@kde.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |aacid@kde.org
>
> --- Comment #6 from Albert Astals Cid <aacid@kde.org> ---
> On the other hand i can't imagine a situation in which i would want that,
> this
> just looks like you're trying to fix a limitation in docear making okular
> do
> something weird.
>
> I mean i am highlighting the text, as a user why would i want the note of
> that
> highlighted text be the test himself?
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
>
Comment 9 Chris George 2015-03-31 16:47:56 UTC
I am working with a text editor/outliner to create academic papers. Having the content of highlighted text appear in the xml metadata would be immensely useful and save considerable time and effort when summarizing papers.
Comment 10 h1304924 2015-10-19 17:53:40 UTC
@John SQ Liu: Are you willing to publish your implementation (ui/pageviewannotator.cpp) of the feature for those who are able to compile the source code by themselves? Gist.github.com would be a good idea.
Comment 11 John SQ Liu 2015-10-19 19:41:48 UTC
I no longer use Docear (I moved to emacs and org-mode) so this off of a version of Okular in March.  But it's a 4 line change so you might be able to merge it without too much work.  Diff below

https://github.com/jsqliu/okular/commit/ee9a8f5272c1ea4b20648fe57b52c726751073aa
Comment 12 h1304924 2015-10-19 21:39:46 UTC
Thanks, it works perfectly.
Comment 13 kde 2016-10-07 13:44:55 UTC
*** This bug has been confirmed by popular vote. ***
Comment 14 Oliver Sander 2016-10-07 13:50:12 UTC
It's not me who decides what goes into okular and what doesn't, but I know that your chances increase if you upload the patch to https://git.reviewboard.kde.org .