Say I have a bunch of tabs open and close the window. As any prudent browser does it asks me if I really want to do this. I am presented with 3 options. The first is to close the tab only the accelator key for that is 'l' and Alt+L works exactly as expected. The other two are to close the window and to cancel. However the accelartor key for both of them is 'c'. Going Alt+C cycles between the two but does not select either. Bizarre but I guess thats what happens in Qt when you have colliding accelerator keys. Point is the close window action and the cancel action should have their own accelerator keys and not but try to hog 'c'. Reproducible: Always
Created attachment 80925 [details] a picture is worth 1000 words
Cannot reproduce, for me accelerator is alt-w (Close _W_indow). I'm not a HIG person but KStandardGuiItem::quit() would suite this better? diff --git a/konqueror/src/konqmainwindow.cpp b/konqueror/src/konqmainwindow.cpp index 8a21c1b..d3c7dcc 100644 --- a/konqueror/src/konqmainwindow.cpp +++ b/konqueror/src/konqmainwindow.cpp @@ -5125,7 +5125,7 @@ void KonqMainWindow::closeEvent( QCloseEvent *e ) i18n("You have multiple tabs open in this window, " "are you sure you want to quit?"), i18nc("@title:window", "Confirmation"), - KStandardGuiItem::closeWindow(), + KStandardGuiItem::quit(), KGuiItem(i18n( "C&lose Current Tab" ), "tab-close"), KStandardGuiItem::cancel(), "MultipleTabConfirm
I don't know why you can't reproduce but see my screenshot. Clearly this problem occurs at least some of the time.
Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone!
Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand. Thank you for helping us make KDE software even better for everyone!
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!