Bug 321688 - KNotification::event() should support QIcon/QImage in addition to QPixmap
Summary: KNotification::event() should support QIcon/QImage in addition to QPixmap
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knotifications
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-27 22:38 UTC by Christoph Feck
Modified: 2014-11-04 09:17 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/knotifications/fc9bfbc78641008d0ca7b303bb0547c73b3e29bd
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Feck 2013-06-27 22:38:10 UTC 
There was a recent commit changing a Nepomuk server tool to use QApplication instead of QCoreApplication, just because it wanted to use KNotification::event() to send events.

Such events are sent over to the knotify daemon via D-Bus, and if the application wants to display an icon, it currently has to use QPixmap.

KNotification::event() should additionally support QIcon and/or QImage for its icons, so that such a server tool can stay a QCoreApplication.

See bug 321499 for an example.
Comment 1 Marco Martin 2014-10-29 13:56:51 UTC 
Git commit fc9bfbc78641008d0ca7b303bb0547c73b3e29bd by Marco Martin.
Committed on 29/10/2014 at 13:55.
Pushed by mart into branch 'master'.

add a new KNotification::Event with icon name

add a convenience call to create knotifications with an icon name
REVIEW:120888

M  +15   -0    src/knotification.cpp
M  +22   -1    src/knotification.h

http://commits.kde.org/knotifications/fc9bfbc78641008d0ca7b303bb0547c73b3e29bd