Bug 321459 - Cannot disable display of holidays
Summary: Cannot disable display of holidays
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-clock (show other bugs)
Version: 4.10.80
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-21 08:46 UTC by Nikos Chantziaras
Modified: 2013-07-17 22:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11


Attachments
Screenshot of Digital Clock's Calendar settings (45.72 KB, image/png)
2013-06-22 07:11 UTC, Nikos Chantziaras
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Chantziaras 2013-06-21 08:46:43 UTC
Clicking on the clock in the panel will pop-up a window showing the calendar to the left and holiday events to the right.

In the "Digital Clock Settings", there doesn't seem to be any way to disable the display of holidays at all. Disabling "Display Kontact events" has no effect. Even though I do not want to see the holidays panel at all, the problem is a bit worse that just that: I'm now stuck with seeing USA holidays while I'm neither an american nor live in the US.

Reproducible: Always
Comment 1 Nikos Chantziaras 2013-06-21 08:47:40 UTC
Forgot to mention that the problem only seems to exist in KDE 4.11 beta1. In 4.10.4, it was possible to disable the holidays display in the clock widget.
Comment 2 Franz Trischberger 2013-06-22 07:07:41 UTC
I think (not know, because I don't have 4.11 running) you can simply go to your clock settings and open "Calendar". The problem: the dialog is way too small to show the whole table. Either scroll it to the right or simply resize the settings dialog, then you can reach the comboboxes to control which holidays to display.
Comment 3 Nikos Chantziaras 2013-06-22 07:11:42 UTC
(In reply to comment #2)
> I think (not know, because I don't have 4.11 running) you can simply go to
> your clock settings and open "Calendar". The problem: the dialog is way too
> small to show the whole table. Either scroll it to the right or simply
> resize the settings dialog, then you can reach the comboboxes to control
> which holidays to display.

No, there's no other settings there (I'm attaching a screenshot.) This looks like a regression.
Comment 4 Nikos Chantziaras 2013-06-22 07:11:49 UTC
Created attachment 80704 [details]
Screenshot of Digital Clock's Calendar settings
Comment 5 Franz Trischberger 2013-06-22 07:21:47 UTC
Ah - I should have had a look at your Distro, first ;)
Gentoo controlled display of holiday events through the "rss" USE-Flag, as rss and holidays both needed kdepimlibs. I did report this unintuitive feature-handling ;) Now as semantic-desktop is not anymore optional in gentoo, the rss-USE-Flag got dropped entirely:

commit b0772937b260533455d20b0ead3139c591a791bc
Author: Michael Palimaka <kensington@gentoo.org>
Date:   Thu May 30 04:29:59 2013 +1000

    [kde-base/plasma-workspace] Drop USE="rss".

So holidays should be there by default.

I would suggest to emerge --sync, rebuild at least kdepimlibs + plasma-workspace. If it still does not show holidays you should contact the Gentoo kde herd (best through Gentoo bugzilla ;))
Comment 6 Nikos Chantziaras 2013-06-22 07:30:40 UTC
(In reply to comment #5)
> I would suggest to emerge --sync, rebuild at least kdepimlibs +
> plasma-workspace.

Er, I should rebuild without changing any USE flags? What would that accomplish? I'd just get the same thing I now have :-|
Comment 7 Franz Trischberger 2013-06-22 08:56:06 UTC
(In reply to comment #6)
> Er, I should rebuild without changing any USE flags? What would that
> accomplish? I'd just get the same thing I now have :-|

I don't think there should be any USE-Flags to consider - everything should work out of the box. I also remembered "kde-base/libplasmaclock" - it had USE="holidays" to enable those holidays. But that got dropped, too.
But since the bump to 4.11 beta1 there were no changes to the relevant ebuilds, also the eclasses did not get changes. So rebuilding might not be the solution though it could still fix your issues magically ;)). Probably there is a build option that needs to get turned on?
Comment 8 Nikos Chantziaras 2013-06-28 14:11:38 UTC
I've updated to 4.10.90, which of course means a full rebuild of everything in KDE. Problem is still there.

Doesn't look like a Gentoo bug. Can *anyone* who is running 4.10.90 please confirm whether he/she is able to disable the display of holidays?
Comment 9 Hrvoje Senjan 2013-06-28 17:00:27 UTC
(In reply to comment #8)
> Doesn't look like a Gentoo bug. Can *anyone* who is running 4.10.90 please
> confirm whether he/she is able to disable the display of holidays?

Confirming the issue (and using master w/ openSUSE). I *suspect* it's due to this commit https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/22bc09c62bc3f305907d7270c650db9d291e5e6a
Comment 10 Hrvoje Senjan 2013-06-28 17:05:10 UTC
(In reply to comment #0)
> the
> problem is a bit worse that just that: I'm now stuck with seeing USA
> holidays while I'm neither an american nor live in the US.

This part works though. English locale, and Country set as Croatia - Croatian holidays are shown
Comment 11 Christophe Marin 2013-07-17 22:07:32 UTC
Git commit 7a8f5904f16b77d52282ba5b0886aad45aa3a1e2 by Christophe Giboudeaux.
Committed on 17/07/2013 at 22:06.
Pushed by cgiboudeaux into branch 'KDE/4.11'.

Use the correct var. It's KdepimLibs_FOUND
FIXED-IN: 4.11

M  +8    -8    libs/plasmaclock/CMakeLists.txt

http://commits.kde.org/kde-workspace/7a8f5904f16b77d52282ba5b0886aad45aa3a1e2