Bug 321159 - Missing translations in kde-desktop-applets
Summary: Missing translations in kde-desktop-applets
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Unmaintained
Component: presence-applet (show other bugs)
Version: 0.6.2
Platform: Other Linux
: NOR major
Target Milestone: 0.6-next
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 21:07 UTC by Daniel Vrátil
Modified: 2013-07-14 20:54 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Vrátil 2013-06-14 21:07:20 UTC
0.6.2 tarball does not contain plasma_applet_org.kde.ktp-presence.po translation for any language, although translations exist in SVN.

Additionally, no translations are being extracted from chat and contactlist applets (missing messages.sh)

Reproducible: Always
Comment 1 Daniele E. Domenichelli 2013-06-14 22:40:10 UTC
Do tarballs for 0.6.0 and 0.6.1 include it?
IIRC the transations are included or excluded depending on the percentage of translated strings, so it might be that not enough strings are translated
Comment 2 Daniel Vrátil 2013-06-15 08:45:30 UTC
Yes, 0.6.1 contains both org.kde.ktp-contact and org.kde.ktp-presence translations. 0.6.0 contains very few org.kde.ktp-presence translations and no org.kde.ktp-contact translations at all.
Comment 3 David Edmundson 2013-06-17 10:08:57 UTC
> Additionally, no translations are being extracted from chat and contactlist applets (missing messages.sh)

They have no i18n strings, hence no Messages.sh
That's no longer true for master, so we must remember to fix that at some point.
Comment 4 David Edmundson 2013-06-17 10:11:10 UTC
This is the config from the createtarball script used to make 0.6.2

[presence-applet]
mainmodule      = extragear
submodule       = network
name            = ktp-desktop-applets
version         = 0.6.2
stable_branch   = yes
docs            = no
translations    = yes
git             = yes
custompo        = plasma_applet_ktp_presence,plasma_applet_org.kde.ktp-contact


The custompo line is wrong I guess. I don't see how 0.6.1 could have them then.
Comment 5 Martin Klapetek 2013-06-17 10:38:58 UTC
> The custompo line is wrong I guess. I don't see how 0.6.1 could have them then.

That's because 0.6.1 was done by me and I actually retarballed ktp-desktop-applets so it contains translations. The custompo should be

custompo        = plasma_applet_org.kde.ktp-contact,plasma_applet_org.kde.ktp-presence
Comment 6 Lukáš Tinkl 2013-06-17 10:42:25 UTC
Yup... may I ask why don't you use the scripts in releaseme repo?
Comment 7 David Edmundson 2013-06-17 10:45:24 UTC
At time of 0.1. Releaseme didn't do git. 
We used one of the many other release scripts, createtarball. It always "worked" so we haven't changed. 

I'd like to switch to releaseme at some point, but it wouldn't have caught or helped with the issue here.
Comment 8 David Edmundson 2013-07-12 13:06:24 UTC
Martin, please make sure you push update to your release script. 

Mark this bug as closed when you do so.

Then I'll do a 0.6.3 whenever.
Comment 9 Martin Klapetek 2013-07-14 20:54:00 UTC
As we're unable to push to collabora servers (where the release script is) and we probably shouldn't rely on them anyway, I've copied it to kde:scratch/mklapetek/createtarball with updated telepathy_config.ini. Wiki updated too.