the feature is simple, remove the filter once you open a chat (or execute any action) the rationale behind it is simple as well, when you filter you do that because you have a concrete reason, like finding david edmunson once I find you, and I execute an action with you (open chat, open kbattleship, etc) the filter should be removed Reproducible: Always
+1 from me. I'll let Martin confirm the bug if he's happy with it too.
Should it just remove the filter string or hide the filter bar too?
Imho hide it too,
I'm not a big fan of this Idea, if you just need to start one action you can just use the krunner... When I'm testing something, I often keep the filter on one account of mine and just keep starting actions on that. If you implement this, I suggest adding some "stick" button to the filter bar, so that you can opt-out this feature when you don't want it.
Well, the interface should be optimized for those users that do not even know that KRunner exists, after all it is still a hidden feature (you need to know the shortcut). About the stick button, if the filterbar was big it wouldn't add too much noise but being usually quite narrow.. I'm not sure. This is a typical case of priorities, by hiding it by default you will probably make life easier to newbie users of the contactlist (like myself) but making it harder to hardcore users. (In reply to comment #4) > I'm not a big fan of this Idea, if you just need to start one action you can > just use the krunner... > When I'm testing something, I often keep the filter on one account of mine > and just keep starting actions on that. > If you implement this, I suggest adding some "stick" button to the filter > bar, so that you can opt-out this feature when you don't want it.
I forgot, can you imagine an use case that can be applied to users, even if they are advanced? the use case you have given is quite specific to developers
(In reply to comment #5) > About the stick button, if the filterbar was big it wouldn't add too much > noise but being usually quite narrow.. I'm not sure. If you have this feature, then you probably don't need the close button anymore, perhaps we can just replace it with a stick button when the field is not empty... (In reply to comment #6) > I forgot, can you imagine an use case that can be applied to users, even if > they are advanced? the use case you have given is quite specific to > developers You choose a contact, then you start some action (let's say you send a file), and then you want to start another one with the same contact (let's say you want to send another file)
I thought about repeated actions. I believe that in most cases you are also chatting with that person and as such you can repeatedly start the same action from the text-ui, which is even easier as it's in a toolbar. Would that satisfy that?
I'm not sure. Given the patch is ready, let's try it first before we come to any conclusions about whether we like it and what we need to change.
Alright, I'll commit it and leave this bug open for now. I'll put this in stable too, so we can get some feedback earlier.
as in 0.6.x?
Well, do/will we have enough stuff to release 0.6.3?
Possibly. There are some patches, nothing worth it at the moment. In either case I don't want this in 0.6. 1) We don't know if it's great or whether it'll suck 2) it's a new feature. Rules are against that. Behaviour shouldn't change in minor releases.
Git commit e0e5d290c5468ca66533907689de61310447ed86 by Martin Klapetek. Committed on 13/06/2013 at 21:19. Pushed by mklapetek into branch 'master'. Automatically hide the filter bar after an action has been started As this makes repeatable actions harder to execute, this patch is mainly for testing purposes, it may be reverted before 0.7, see the bug for details FIXED-IN: 0.7.0 REVIEW: 110998 M +12 -0 contact-list-widget.cpp M +1 -1 contact-list-widget.h M +6 -0 filter-bar.cpp M +3 -0 filter-bar.h M +3 -0 main-widget.cpp http://commits.kde.org/telepathy-contact-list/e0e5d290c5468ca66533907689de61310447ed86